PHP Code and Code Style cleanup in utility.inc file. [#1965200]

I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.

And also, this is my first patch to the D8 core. So bare with me if I do something not as expected.

Checked: utility.inc file.

Comment	File	Size	Author
#4	drupal_core-code_cleanup_doc_cleanup-1965200-4.patch	999 bytes	ro-no-lo
#1	drupal_core-code_cleanup_doc_cleanup-1965200.patch	999 bytes	ro-no-lo

Comments

Comment #1

ro-no-lo commented 9 April 2013 at 08:18

Status:

Active

» Needs review

Status	File	Size
new	drupal_core-code_cleanup_doc_cleanup-1965200.patch	999 bytes

Comment #2

9 April 2013 at 08:20

Status:

Needs review

» Needs work

The last submitted patch, drupal_core-code_cleanup_doc_cleanup-1965200.patch, failed testing.

Comment #3

ro-no-lo commented 9 April 2013 at 08:22

Status:

Needs work

» Needs review

Damn I diffed into the wrong direction.

Comment #4

ro-no-lo commented 9 April 2013 at 12:18

Status	File	Size
new	drupal_core-code_cleanup_doc_cleanup-1965200-4.patch	999 bytes

Did the patch file again.

Comment #5

manarth commented 30 June 2013 at 10:48

Status:

Needs review

» Reviewed & tested by the community

+1. The removal of line $line_safe_var = str_replace("\n", '\n', $var); looked odd, but the $line_safe_var variable is not used later in the function.