Follow up for #1862512-15: Convert drupal_http_request usage in xmlrpc.module to Guzzle

Problem/Motivation

Frequently
Invalid values generate a list of form errors. Other EntityTranslationUITest.php 40 Drupal\translation_entity\Tests\EntityTranslationUITest->testTranslationUI()
is a random test failure... too frequent to be really random.

Proposed resolution

Let's look for other issues that have seen this and also see if we can find the cause.

Remaining tasks

TBD

User interface changes

No UI changes.

API changes

No API changes aniticipated.

Original report by @Berdir

in #1862512-15: Convert drupal_http_request usage in xmlrpc.module to Guzzle

Invalid values generate a list of form errors. Other EntityTranslationUITest.php 40 Drupal\translation_entity\Tests\EntityTranslationUITest->testTranslationUI()

Seen that one a lot recently, in various translation UI tests.

Files: 
CommentFileSizeAuthor
#2 drupal-1965048-2-fail.patch976 bytesolli
FAILED: [[SimpleTest]]: [MySQL] 55,872 pass(es), 5 fail(s), and 0 exception(s).
[ View ]
#2 drupal-1965048-2.patch978 bytesolli
PASSED: [[SimpleTest]]: [MySQL] 56,257 pass(es).
[ View ]

Comments

Berdir’s picture

Title:frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors.» Frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors.
Category:task» bug
Issue tags:-d8dx+Random test failure
olli’s picture

StatusFileSize
new978 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,257 pass(es).
[ View ]
new976 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,872 pass(es), 5 fail(s), and 0 exception(s).
[ View ]

I've seen this too.

olli’s picture

Status:Active» Needs review
Berdir’s picture

Status:Needs review» Reviewed & tested by the community

Nice find. Fix looks good to me, although it's not 100% clear to me what exactly causes it to work/fail but the old value certainly didn't make sense and the fail test shows that you can make it fail with the wrong random string :)

Testbot doesn't return the results somehow, checked with @rfay and re-tested the one that should pass. But if you click on it you can see that it's green/red as it should be.

ParisLiakos’s picture

Priority:Normal» Critical

yes please!
and bumping to critical cause i ve seen it twice today

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Lovely...

Committed 7e7b0f0 and pushed to 8.x. Thanks!

tim.plunkett’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.