Frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors. [#1965048]

Follow up for #1862512-15: Convert drupal_http_request usage in xmlrpc.module to Guzzle

Problem/Motivation

Frequently
Invalid values generate a list of form errors. Other EntityTranslationUITest.php 40 Drupal\translation_entity\Tests\EntityTranslationUITest->testTranslationUI()
is a random test failure... too frequent to be really random.

Proposed resolution

Let's look for other issues that have seen this and also see if we can find the cause.

Remaining tasks

TBD

User interface changes

No UI changes.

API changes

No API changes aniticipated.

Original report by @Berdir

in #1862512-15: Convert drupal_http_request usage in xmlrpc.module to Guzzle

Invalid values generate a list of form errors. Other EntityTranslationUITest.php 40 Drupal\translation_entity\Tests\EntityTranslationUITest->testTranslationUI()

Seen that one a lot recently, in various translation UI tests.

Comment	File	Size	Author
#2	drupal-1965048-2-fail.patch	976 bytes	olli
#2
#2	drupal-1965048-2.patch	978 bytes	olli
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Berdir

German

Switzerland

CreditAttribution: Berdir commented 9 April 2013 at 08:26

Title:	frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors.	» Frequent random test failure EntityTranslationUITest Invalid values generate a list of form errors.
Category:	task	» bug
Issue tags:	-d8dx	+Random test failure

Comment #2

olli CreditAttribution: olli commented 23 May 2013 at 19:01

File	Size
drupal-1965048-2.patch	978 bytes

drupal-1965048-2-fail.patch	976 bytes

I've seen this too.

Comment #3

olli CreditAttribution: olli commented 23 May 2013 at 19:16

Status:

Active

» Needs review

Comment #4

Berdir

German

Switzerland

CreditAttribution: Berdir commented 23 May 2013 at 21:42

Status:

Needs review

» Reviewed & tested by the community

Nice find. Fix looks good to me, although it's not 100% clear to me what exactly causes it to work/fail but the old value certainly didn't make sense and the fail test shows that you can make it fail with the wrong random string :)

Testbot doesn't return the results somehow, checked with @rfay and re-tested the one that should pass. But if you click on it you can see that it's green/red as it should be.