Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.That tests verifies that the load/save/delete hooks are called and does so by adding an additional thing to the term that is stored in an arbitrary table.
- We already have tests for taxonomy hooks in EntityCrudHookTest
- This test predates fieldable terms, this shouldn't be done using a custom table and custom code but by using a field. So it's a bad example.
Let's remove it.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | core-remove_taxonomy_tests-1962806-12.patch | 8.12 KB | mtift |
| #8 | core-remove_taxonomy_tests-1962806-8.patch | 8.11 KB | mtift |
| #4 | core-remove_taxonomy_tests-1962806-4.patch | 7.75 KB | mtift |
| #4 | interdiff.txt | 1.55 KB | mtift |
| #2 | core-remove_taxonomy_tests-1962806-2.patch | 6.21 KB | mtift |
Comments
Comment #1
mtiftI'll do this
Comment #2
mtiftAnd the patch.
Comment #3
berdirI think there's also an taxonomy_test.install and .info.yml file that you can delete now. Looks good otherwise, thanks.
Comment #4
mtiftAdditional files removed
Comment #5
berdir#4: core-remove_taxonomy_tests-1962806-4.patch queued for re-testing.
Comment #7
berdirThis will need a re-roll now. The easiest way is probably just to re-remove the files and create a new patch.
Comment #8
mtiftThis patch re-removes the files
Comment #9
berdirThanks, let's do this.
Comment #10
catch#8: core-remove_taxonomy_tests-1962806-8.patch queued for re-testing.
Comment #12
mtiftre-removes the files again
Comment #13
berdirQuite a bad timing with this, let's get it in now. RTBC if testbot agrees.
Comment #14
alexpottCommitted 4ec9347 and pushed to 8.x. Thanks!