That tests verifies that the load/save/delete hooks are called and does so by adding an additional thing to the term that is stored in an arbitrary table.

- We already have tests for taxonomy hooks in EntityCrudHookTest
- This test predates fieldable terms, this shouldn't be done using a custom table and custom code but by using a field. So it's a bad example.

Let's remove it.

Comments

mtift’s picture

Assigned: Unassigned » mtift

I'll do this

mtift’s picture

Status: Active » Needs review
StatusFileSize
new6.21 KB

And the patch.

berdir’s picture

Status: Needs review » Needs work

I think there's also an taxonomy_test.install and .info.yml file that you can delete now. Looks good otherwise, thanks.

mtift’s picture

Status: Needs work » Needs review
StatusFileSize
new1.55 KB
new7.75 KB

Additional files removed

berdir’s picture

Issue tags: -Novice, -Entity Field API

Status: Needs review » Needs work
Issue tags: +Novice, +Entity Field API

The last submitted patch, core-remove_taxonomy_tests-1962806-4.patch, failed testing.

berdir’s picture

This will need a re-roll now. The easiest way is probably just to re-remove the files and create a new patch.

mtift’s picture

Status: Needs work » Needs review
StatusFileSize
new8.11 KB

This patch re-removes the files

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, let's do this.

catch’s picture

Issue tags: -Novice, -Entity Field API

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +Entity Field API

The last submitted patch, core-remove_taxonomy_tests-1962806-8.patch, failed testing.

mtift’s picture

Status: Needs work » Needs review
StatusFileSize
new8.12 KB

re-removes the files again

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Quite a bad timing with this, let's get it in now. RTBC if testbot agrees.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4ec9347 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.