In-place editing not working because alpha 8 uses jQuery UI 1.10 [#1961746]

Fresh install of alpha8. (tested in chrome/firefox on mac)

I get a javascript error when hitting the "quick edit" link.
Result is the white overlay appears but no editing is possible.
Upon closing you get an other error.

Console traces of both:

Uncaught TypeError: Cannot read property 'element' of undefined create-editonly.js:341
jQuery.widget._params create-editonly.js:341
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
jQuery.widget._enablePropertyEditor create-editonly.js:600
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
(anonymous function) create-editonly.js:489
e.extend.each jquery.min.js:2
e.fn.e.each jquery.min.js:2
jQuery.widget.findEditablePredicateElements create-editonly.js:475
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
jQuery.widget.enable create-editonly.js:488
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
jQuery.widget._doSetState create-editonly.js:464
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
(anonymous function) create-editonly.js:446
Drupal.edit.EditAppView.Backbone.View.extend.acceptEditorStateChange app.js:245
jQuery.widget.setState create-editonly.js:444
e.isFunction.l.(anonymous function) jquery.ui.widget.min.js:4
(anonymous function) jquery.ui.widget.min.js:4
e.extend.each jquery.min.js:2
e.fn.e.each jquery.min.js:2
e.fn.(anonymous function) jquery.ui.widget.min.js:4
(anonymous function) app.js:134
e.extend.each jquery.min.js:2
e.fn.e.each jquery.min.js:2

Drupal.edit.EditAppView.Backbone.View.extend.appStateChange app.js:133
Backbone.Events.trigger backbone.js:157
_.extend.change backbone.js:469
_.extend.set backbone.js:314
Drupal.edit.views.MenuView.Backbone.View.extend.editClickHandler menu-view.js:48
f.event.dispatch jquery.min.js:3
h.handle.i jquery.min.js:3
Uncaught TypeError: Cannot call method 'removeAttr' of undefined app.js:550
Drupal.edit.EditAppView.Backbone.View.extend._releaseDocumentFocusManagement app.js:550
Drupal.edit.EditAppView.Backbone.View.extend.appStateChange app.js:142
Backbone.Events.trigger backbone.js:157
_.extend.change backbone.js:469
_.extend.set backbone.js:314
Drupal.edit.views.OverlayView.Backbone.View.extend.onClick overlay-view.js:59
f.event.dispatch jquery.min.js:3
h.handle.i jquery.min.js:3

Comments

Comment #1

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 5 April 2013 at 11:14

Title:	Inline editing not working	» In-place editing not working because alpha 8 uses jQuery UI 1.10
Assigned:	Unassigned	» Wim Leers
Priority:	Normal	» Critical

Confirmed.

This is because Spark 7 1.0 alpha 8 (and 1.x HEAD) currently uses the 2.x-dev version of jquery_update, which just recently got updated to use jQuery UI 1.10, which breaks Create.js, which in turn breaks in-place editing.

This also caused breakage in Drupal 8, but I managed to write a patch to fix this just yesterday: #1960612-3: jQuery UI 1.10 update broke Create.js, and thus in-place editing.

In D7, I'm solving this at #1962274: jQuery UI 1.10 compatibility.

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 5 April 2013 at 11:26

Issue tags:

+sprint, +Spark

Solving this is currently blocked on upstream feedback because Edit ideally doesn't *require* jQuery UI 1.10, see #1962274-2: jQuery UI 1.10 compatibility for details.

For now, the easiest solution is to modify Spark to use version 7.x-2.3 of jquery_update specifically, instead of 7.x-2.x-dev.

Comment #3

garbo CreditAttribution: garbo commented 27 May 2013 at 19:21

By downgrading to jquery_update 7.x-2.3 I'm running into trouble with the navigation bar. The submenu's don't receive their css postion-top declarations and are now effectively hidden behind the main level (the black bar).

This only happens on the front-end though (Bartik theme).