Loads the frontend version on ajax calls on backend pages [#1954930]

After #1524944: Allow different version for administrative pages:

* Set jquery 1.8 for front end pages.
* Set jquery 1.7 for back end pages.
* Go to a node with a media field
* Add a file to the media field
* Save
* Edit the node
* Click on Remove next to the media field

Te site does nothing but it should show a popup. The problem seems to be that in this point (and some other places too) it's trying to load jquery 1.8:

GET ...jquery/1.8/jquery.min.js?v=1.8.2&_=1364428694695    200 OK   jquery...v=1.7.1 (line 4)
GET ...ox/jquery.colorbox-min.js?mkc9hs&_=1364428694905   200 OK   jquery...v=1.7.1 (line 4)
GET ...b/colorbox/js/colorbox.js?mkc9hs&_=1364428694987    200 OK   jquery...v=1.7.1 (line 4)
GET ...colorbox_default_style.js?mkc9hs&_=1364428695069    200 OK   jquery...v=1.7.1 (line 4)
TypeError: $(...).filter(...).once(...).colorbox is not a function
[Break On This Error] 	
.colorbox(settings.colorbox);

Comment	File	Size	Author
#6	jquery_update-fix_ajax_calls-1954930-6.patch	1.42 KB	lucascaro
#6
#4	jquery_update-fix_ajax_calls-1954930-4.patch	1.74 KB	lucascaro
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lucascaro CreditAttribution: lucascaro commented 2 April 2013 at 21:56

Title:

Setting different versions for frontend and admin leads to errors.

» Loads the frontend version on ajax calls on backend pages

Debugging this I realized that when doing an ajax call from the backend, jquery_update has no way to know and attempts to load the frontend version of jquery, causing an error and breaking ajax calls.

current_paths for ajax calls might not be marked as admin paths, but they need to use the same jquery version as the original page.

  if (!empty($admin_version) && path_is_admin(current_path())) {
    if (version_compare($version, $admin_version, '!=')) {
      $version = $admin_version;
    }
  }

Comment #2

lucascaro CreditAttribution: lucascaro commented 2 April 2013 at 22:01

This might be related to #1957782: ['ajax_page_state']['jquery_version'] not sent back to the server

Comment #3

lucascaro CreditAttribution: lucascaro commented 3 April 2013 at 01:00

Status:

Active

» Needs review

I've found an error on jquery_update.module:207

 if (!empty($_POST['ajax_page_state']['jquery_version'])) {
    $ajax_version = $_POST['ajax_page_state']['jquery_version'];
    if (in_array($valid_version, array('1.5', '1.6', '1.7'))) {
      $version = $ajax_version;
    }
  }

The if clause is using a undefined variable, it should be using $ajax_version instead.

I also had to add the following script to make it work (inspired on http://drupal.org/node/1957782):

(function (D) {
  var beforeSerialize = D.ajax.prototype.beforeSerialize;
  D.ajax.prototype.beforeSerialize = function (element, options) {
    beforeSerialize.call(this, element, options);
    options.data['ajax_page_state[jquery_version]'] = D.settings.ajaxPageState.jquery_version;
  }
})(Drupal);

With these two changes it's working on my end. Ill post a patch ASAP.

Comment #4

lucascaro CreditAttribution: lucascaro commented 3 April 2013 at 01:02

File	Size
jquery_update-fix_ajax_calls-1954930-4.patch	1.74 KB

Here's the patch:

Comment #5

Punk_UnDeaD

Russian

CreditAttribution: Punk_UnDeaD commented 3 April 2013 at 07:49

don't use drupal_add_js
it fix for drupal.ajax library, not an independent file
use something like


$javascript['drupal.ajax']['js'][] = array(
    'data' => array('ajaxPageState' => array('jquery_version' => $version)),
    'type' => 'setting'
  );
  $javascript['drupal.ajax']['js'][$path . '/jquery_update.js'] = $javascript['drupal.ajax']['js']['misc/ajax.js'];

Comment #6

lucascaro CreditAttribution: lucascaro commented 3 April 2013 at 16:49

File	Size
jquery_update-fix_ajax_calls-1954930-6.patch	1.42 KB

re-roll with the change from #5

Comment #7

ericduran CreditAttribution: ericduran commented 5 April 2013 at 17:18

Hmm, The beforeSerialize shouldn't be require. That is why I added the POST check.

How is the Ajax request being made? If the ajax request is properly being done using Drupal Ajax system the post value should be there.

I'm going to need to test this before this patch can be added.

Comment #8

Punk_UnDeaD

Russian

CreditAttribution: Punk_UnDeaD commented 8 April 2013 at 08:20

not all data collect to send
only ajax_html_ids, ajax_page_state[theme], ajax_page_state[theme_token], ajax_page_state[css] and ajax_page_state[js]

see Drupal.ajax.prototype.beforeSerialize

Comment #9

ericduran CreditAttribution: ericduran commented 8 April 2013 at 19:25

@Punk_UnDeaD Ahh, It's because I only tested with ajax forms which does return the entire Drupal.settings.

Reviewing the patch now.

Thanks.

Comment #10

ericduran CreditAttribution: ericduran commented 8 April 2013 at 19:44

+++ b/jquery_update.moduleundefined
@@ -92,6 +92,8 @@ function jquery_update_library_alter(&$javascript, $module) {
+  $javascript['drupal.ajax']['js'][$path . '/js/jquery_update.js'] = $javascript['drupal.ajax']['js']['misc/ajax.js'];

We should actually change the weight to go right after the ajax script.

Lets not leave the weight the same to make it clear that we want that specific order.

The rest looks good.

Thanks all.