Needs review
Project:
Garlic
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2013 at 10:12 UTC
Updated:
21 Oct 2015 at 13:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
minoroffense commentedI can see what I can do. But that is a very large patch. Perhaps break it down into parts and individual tasks to make our lives easier for adding additional integration.
Comment #2
wim leersThat patch contains the library itself *and* tests. The relevant parts are very small, actually.
Comment #3
chellman commentedI've been investigating autosave, and hadn't heard of Garlic.js, let alone the D8 issue trying to integrate it. But I could really use this for Drupal 7, so here's an initial cut at backporting the goods from that D8 issue.
There's nothing in here to auto-connect any forms to Garlic - you still would need to hook_form_alter the ones you want to enable it on. If this actually works for other people, I wouldn't mind throwing in a settings screen to enable it on node edit forms by default, say.
There's also some extra work needed for Garlic to work on WYSIWYG-enabled textareas, but not much. The following worked for me, as long as you have CKEditor 4.2+ installed:
Comment #4
chellman commentedComment #5
minoroffense commentedComment #6
jbrown commentedbefore passing to js.
Comment #7
plazik commentedCkeditor code from #3 doesn't work for me.
Here is working code for 4.5:
Comment #8
franzSome updates here:
Comment #9
franzI was using the garlic.js version in the make.example file.
Comment #10
franzI was also having trouble with Autocomplete field + click + Chrome. Adding the "formUpdated" event to garlic options fixed.