The files which could be swapped with these Settings have been gutted in D8 and their functionality moved to swappable services. Lets cleanup unneeded Settings.

Old Summary

In _drupal_bootstrap_full(), you can see the following:

  require_once DRUPAL_ROOT . '/' . settings()->get('path_inc', 'core/includes/path.inc');

This is a perfect candidate for the DIC. Conditionally switching PHP files is an old methodology, and we can do better.

CommentFileSizeAuthor
#6 no.incs-1949204-6.patch2.38 KBmoshe weitzman
#3 no.incs-1949204-2.patch2.38 KBmoshe weitzman
#1 move_path_inc_to_a_path-1949204-1.patch2.39 KBmoshe weitzman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Title: Move path.inc to a Path Service in the DIC » Remove path_inc and menu_inc Settings
Assigned: Unassigned » moshe weitzman
Issue summary: View changes
Status: Active » Needs review
FileSize
move_path_inc_to_a_path-1949204-1.patch2.39 KB

The files which could be swapped with these Settings have been gutted in D8 and their functionality moved to swappable services. Lets cleanup unneeded Settings.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Needs work 
+++ b/core/includes/theme.maintenance.inc
@@ -23,7 +23,7 @@ function _drupal_maintenance_theme() {
-  require_once DRUPAL_ROOT . '/' . Settings::get('path_inc', 'core/includes/path.inc');
+  require_once __DIR__ . 'core/includes/path.inc';
   require_once __DIR__ . '/theme.inc';

This doesn't look correct.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs work » Needs review
FileSize
no.incs-1949204-2.patch2.38 KB

thx. fixed.

The last submitted patch, 1: move_path_inc_to_a_path-1949204-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: no.incs-1949204-2.patch, failed testing.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs work » Needs review
FileSize
no.incs-1949204-6.patch2.38 KB

Stray parens

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Awesome, no usages left! This has been bugging me everytime I've seen it for a while, thanks for cleaning this up.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 0acde17 and pushed to 8.0.x. Thanks!

  • alexpott committed 0acde17 on 8.0.x 
    Issue #1949204 by moshe weitzman | RobLoach: Remove path_inc and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.