drupal-org.make brings HTML for json2.js [#1946274]

Problem/Motivation

Running "drush make build-spark.make /path/to/wwwroot" will run drupal-org.make and it is supposed to download the json2.js within the libraries folder (/path/to/wwwroot/profiles/spark/libraries/json2/)

Proposed resolution

A change is needed in drupal-org.make, line 129, to:
libraries[json2][download][url] = https://raw.github.com/douglascrockford/JSON-js/master/json2.js
So we can download the correct Javascript library.

Comment	File	Size	Author
#2	spark-fix-to-json2-library-1946274-1.patch	625 bytes	jmcoimbra

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jmcoimbra CreditAttribution: jmcoimbra commented 18 March 2013 at 20:51

Title:	drupal-org.make brings HTML from https://github.com/douglascrockford/JSON-js/blob/master/json2.js	» drupal-org.make brings HTML for json2.js
Issue tags:		+JavaScript, +issue, +Libraries, +json2

Updating title to avoid spam filter

Comment #2

jmcoimbra CreditAttribution: jmcoimbra commented 18 March 2013 at 21:09

File	Size
spark-fix-to-json2-library-1946274-1.patch	625 bytes

Comment #3

jmcoimbra CreditAttribution: jmcoimbra commented 19 March 2013 at 00:29

Status:

Active

» Needs review

Sorry guys, I am new contributing to Drupal. =)
I don't know the flow of this fix... I think someone other then me must test it.

Thanks

Comment #4

jmcoimbra CreditAttribution: jmcoimbra commented 19 March 2013 at 12:14

Status:

Needs review

» Active

Comment #5

jmcoimbra CreditAttribution: jmcoimbra commented 20 March 2013 at 12:36

Assigned:

jmcoimbra

» Unassigned

Comment #6

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 20 March 2013 at 14:26

Did github change URL patterns recently? I see currently the new URL works better, but the old one used to work too.

Comment #7

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 20 March 2013 at 14:32

Status:

Active

» Fixed

Looked at how the raw URL is produced on github and it indeed now points to this new URL. So committed this and fixed the whitelist pattern at http://drupal.org/node/1404070 to allow for this URL form too for this lib.