Files: 
CommentFileSizeAuthor
#5 shortcut-1945564-5.patch18.75 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 53,781 pass(es).
[ View ]
#5 interdiff.txt4.18 KBtim.plunkett
#3 shortcut-1945564-3.patch15.67 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 53,211 pass(es), 4 fail(s), and 5 exception(s).
[ View ]
#3 interdiff.txt881 bytestim.plunkett
#1 shortcut-1945564-1.patch15.91 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Comments

tim.plunkett’s picture

Status:Active» Needs review
StatusFileSize
new15.91 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Okay, here's a conversion. However, it seems that _menu_link_translate() completely skips the applies() method of access checkers, and calls access() blindly. I'll have to check in with Crell on that.

Oh yeah, and all the breadcrumbs/active trail are screwed up.

Status:Needs review» Needs work

The last submitted patch, shortcut-1945564-1.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new881 bytes
new15.67 KB
FAILED: [[SimpleTest]]: [MySQL] 53,211 pass(es), 4 fail(s), and 5 exception(s).
[ View ]

Whoops, shouldn't have outright removed shortcut_link_access().

Status:Needs review» Needs work

The last submitted patch, shortcut-1945564-3.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new4.18 KB
new18.75 KB
PASSED: [[SimpleTest]]: [MySQL] 53,781 pass(es).
[ View ]

Okay, switched to an access controller.
We should scheme up a more generic one of those for entities.

Status:Needs review» Needs work
Issue tags:-FormInterface

The last submitted patch, shortcut-1945564-5.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
Issue tags:+FormInterface

#5: shortcut-1945564-5.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett’s picture

This conversion is probably going to go in as part of #1947432: Add a generic EntityAccessCheck to replace entity_page_access(). Stay tuned.

jibran’s picture

Status:Postponed» Fixed
tim.plunkett’s picture

Status:Fixed» Closed (duplicate)

Ah, yes.