node_theme() doesn't declare the file that theme_node_admin_overview() lives in.

This doesn't cause a problem for node module, since it only invokes that theme function from inside that file.

But it's a WTF for another module wanting to use that theme function.
It's also a potential future bug should we ever move some of that code around.

CommentFileSizeAuthor
#6 1945066-6-node-theme.patch434 bytesdcam
#1 add-file-declaration-for-node_theme-1945066-1.patch454 byteschertzog

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Needs review
StatusFileSize
new add-file-declaration-for-node_theme-1945066-1.patch454 bytes

Here you go.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks perfect, thanks!

xjm’s picture

xjm
she/her
Primary language English
commented

#1: add-file-declaration-for-node_theme-1945066-1.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Oh, this has bit me before too! Thanks for the fix!

Committed and pushed to 8.x. Moving down to 7.x.

dcam’s picture

dcam commented
StatusFileSize
new 1945066-6-node-theme.patch434 bytes

Backported #1 to D7.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review

Status....

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/7ba00c1

Automatically closed -- issue fixed for 2 weeks with no activity.