node_theme() doesn't declare the file that theme_node_admin_overview() lives in.

This doesn't cause a problem for node module, since it only invokes that theme function from inside that file.

But it's a WTF for another module wanting to use that theme function.
It's also a potential future bug should we ever move some of that code around.

Files: 
CommentFileSizeAuthor
#6 1945066-6-node-theme.patch434 bytesdcam
PASSED: [[SimpleTest]]: [MySQL] 40,294 pass(es). View
#1 add-file-declaration-for-node_theme-1945066-1.patch454 byteschertzog
PASSED: [[SimpleTest]]: [MySQL] 53,386 pass(es). View

Comments

chertzog’s picture

Status:Active» Needs review
FileSize
454 bytes
PASSED: [[SimpleTest]]: [MySQL] 53,386 pass(es). View

Here you go.

joachim’s picture

Status:Needs review» Reviewed & tested by the community

Looks perfect, thanks!

xjm’s picture

xjm’s picture

Issue tags:+Quick fix
webchick’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Oh, this has bit me before too! Thanks for the fix!

Committed and pushed to 8.x. Moving down to 7.x.

dcam’s picture

FileSize
434 bytes
PASSED: [[SimpleTest]]: [MySQL] 40,294 pass(es). View

Backported #1 to D7.

dcam’s picture

Status:Patch (to be ported)» Needs review

Status....

joachim’s picture

Status:Needs review» Reviewed & tested by the community
David_Rothstein’s picture

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.