PHP Notice: Undefined index: pass during installation

can't reproduce this on XAMPP

Duplicate: http://drupal.org/node/193891

No, this is not a duplicate, and still not solved. I tried to install HEAD just now, with E_ALL errors on, and the installer breaks in two places, both becaues I don't have a MySQL password on my local machine.

Attached patch fixes both notices.

I debugged, and can confirm that url[] does not have pass index defined when the database connection is without password
but I can't see the error message

so the question is: where is the message?
do you see it on page "Verify requirements", which page is skipped at install to me,
or do you use some special tool to track php notices,
or do you see it in some log file,
or is it displayed by MAMP?

ok, reproduced (I use XAMPP, so needed some tweaking, but learned something new)

Notice: Undefined index: pass in \install.php on line 158
Notice: Undefined index: pass in \includes\install.mysqli.inc on line 32

php.ini
error_reporting = E_ALL
log_errors = On
error_log = "E:\XAMPP\apache\logs\phperror.log"

restart apache

the key is the error_reporting = E_ALL, because drupal sets this variable after the notice

testing...

the patch works

Thanks, committed.

The patch isn't ok. If you check for an isset you should set the value to the empty string in stead of NULL. Because else the next isset will trigger again. Moreover, this should be fixed for the other db's as well.

So I include a patch that converts the NULL to "" and does the isset for the other db types as well.

Well, I've tested it myself and it works. So if you want to get rid of the notice on an empty password for mysql too, please commit.

Actually, the same code was already present in the runtime versions of these files, just it was a bit more verbose. Now unified to use the same syntax, committed the attached patch.