This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes).
Files need to be fixed
menu.menu.tools.yml
menu.menu.main.yml
menu.menu.admin.yml
menu.menu.account.yml
Files fixed already
menu.setttings.yml
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1942152-menu-config-fix-5.patch | 2.12 KB | rajneeshb |
| #1 | 1942152-menu-config-fix-1.patch | 1.71 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Comment #3
vijaycs85#1: 1942152-menu-config-fix-1.patch queued for re-testing.
Comment #4
sandipmkhairnar commentedIt looks good for me.
Comment #5
rajneeshb commentedI have checked 1942152-menu-config-fix-1.patch and found that single word also within single quote. I think no need to wrap single word in quotes. So I have recreated patch.
Comment #7
yesct commented@rajneeshb an interdiff is awesome when adding a new patch to an issue:
For instructions on creating an interdiff, see http://drupal.org/node/1488712 Or, http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...
Comment #8
yesct commentedfailure was:
The test did not complete due to a fatal error. Completion check MinimalTest.php 30 Drupal\minimal\Tests\MinimalTest->testMinimal()
Retesting.
Comment #9
yesct commented#5: 1942152-menu-config-fix-5.patch queued for re-testing.
Comment #10
vijaycs85This is good to go, if test comes back green.
Comment #11
vijaycs85#5: 1942152-menu-config-fix-5.patch queued for re-testing.
Comment #12
alexpottCommitted 130a554 and pushed to 8.x. Thanks!