This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes).

Files need to be fixed
menu.menu.tools.yml
menu.menu.main.yml
menu.menu.admin.yml
menu.menu.account.yml

Files fixed already
menu.setttings.yml

Files: 
CommentFileSizeAuthor
#5 1942152-menu-config-fix-5.patch2.12 KBrajneeshb
PASSED: [[SimpleTest]]: [MySQL] 54,259 pass(es). View
#1 1942152-menu-config-fix-1.patch1.71 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 53,100 pass(es). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
1.71 KB
PASSED: [[SimpleTest]]: [MySQL] 53,100 pass(es). View

Status: Needs review » Needs work
Issue tags: -Configuration system, -Config novice

The last submitted patch, 1942152-menu-config-fix-1.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
Issue tags: +Configuration system, +Config novice

#1: 1942152-menu-config-fix-1.patch queued for re-testing.

sandipmkhairnar’s picture

It looks good for me.

rajneeshb’s picture

FileSize
2.12 KB
PASSED: [[SimpleTest]]: [MySQL] 54,259 pass(es). View

I have checked 1942152-menu-config-fix-1.patch and found that single word also within single quote. I think no need to wrap single word in quotes. So I have recreated patch.

Status: Needs review » Needs work

The last submitted patch, 1942152-menu-config-fix-5.patch, failed testing.

YesCT’s picture

@rajneeshb an interdiff is awesome when adding a new patch to an issue:
For instructions on creating an interdiff, see http://drupal.org/node/1488712 Or, http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...

YesCT’s picture

failure was:
The test did not complete due to a fatal error. Completion check MinimalTest.php 30 Drupal\minimal\Tests\MinimalTest->testMinimal()

Retesting.

YesCT’s picture

Status: Needs work » Needs review

#5: 1942152-menu-config-fix-5.patch queued for re-testing.

vijaycs85’s picture

Status: Needs review » Reviewed & tested by the community

This is good to go, if test comes back green.

vijaycs85’s picture

#5: 1942152-menu-config-fix-5.patch queued for re-testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 130a554 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.