When I click on a Manualcrop thumbnail to edit crop area in the overlay, I always get error message

Uncaught TypeError: Cannot read property 'width' of null when opening crop UI

in 266 line of manualcrop.js.
The reason is that ManualCrop.oldSelection is not defined in that line, when maximizeDefaultCropArea option is ON.

See the patch.

CommentFileSizeAuthor
#1 manualcrop-1941024-1.patch1.52 KBOnkelTem
undefined-oldSelection.patch1.13 KBOnkelTem

Comments

OnkelTem’s picture

OnkelTem commented
StatusFileSize
new manualcrop-1941024-1.patch1.52 KB

Heh.. I was gonna save time by not creating a local branch for such a minor change, but after all I decided to do everything uniformly.

matthijs’s picture

matthijs
Primary language Dutch
commented
Assigned: Unassigned » matthijs
Status: Needs review » Fixed

Thanks for the patch, it has been committed!

Matthijs

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.