Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
typed data system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
9 Mar 2013 at 16:28 UTC
Updated:
29 Jul 2014 at 22:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
corvus_ch commentedAnd here comes the patch.
Comment #2
berdirComment #3
berdirThis is using two different files to make sure that changing the value actually works.
So you probably need to create two images (can both be druplicon.png as source I think).
Comment #4
fagoComment #5
corvus_ch commentedNext try.
Comment #6
corvus_ch commentedComment #7
berdirThis looks good. We can open a follow-up issue to split the huge class into multiple classes with more separate test methods so that it's more like a unit and not a web test. We can also add a base test class then but it's not that useful to add a base class if we currently only have a single class that would use it.
Comment #8
xanoThe TypedDataTest::createTypedData() $context parameter defaults to an array, but it is passed on as the $name parameter to TypedDataManager::create(), which should be a string. @fago confirmed this on IRC:
Comment #9
xanoNow with parameter name change.
Comment #10
berdirClean-up looks correct and seems to be blocking other tests. Back to RTBC.
Comment #11
webchickGreat, faster tests++ :)
Committed and pushed to 8.x. Thanks!