There are several code style problems with image.schema.yml, keys shouldn't have quotes at all, and values should have single quotes instead of double quotes.

Files: 
CommentFileSizeAuthor
#5 drupal-image-config-schema-code-style-fix-1938158-5.patch2.23 KBMegaChriz
PASSED: [[SimpleTest]]: [MySQL] 52,734 pass(es). View

Comments

Gábor Hojtsy’s picture

MegaChriz’s picture

Assigned: Unassigned » MegaChriz

I'll take a look, though I'm completely new to yml.

Gábor Hojtsy’s picture

Title: Fix code style of image schema » Fix code style of image module configuration schema
Assigned: MegaChriz » Unassigned
MegaChriz’s picture

Assigned: Unassigned » MegaChriz
MegaChriz’s picture

Status: Active » Needs review
FileSize
2.23 KB
PASSED: [[SimpleTest]]: [MySQL] 52,734 pass(es). View

If I understood the issue well, then this patch should fix the code style issue.

MegaChriz’s picture

Assigned: MegaChriz » Unassigned

Forgot to unassign.

clemens.tolboom’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good. tnx @MegaChriz

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, this was one of the first conversions so it's possible we didn't know best practices back then. :)

Committed and pushed to 8.x!

Automatically closed -- issue fixed for 2 weeks with no activity.