Hello,
This is probably a moot point because I realize the 2.x branch is well underway and is a considerable change from the current 1.7 release. Although the issue I am having is with 1.7, it may be something useful to consider for the 2.x branch as well, though I have, admittedly, not tested against the development branch due to uncertainty about its stability.
Basically the issue is that applying jQuery UI button to checkboxes in the module filter list breaks the functionality of module filter itself. It is an easy issue to fix, and a patch is forthcoming. It comes down to relationships defined within the jQuery selectors. The ends of the selectors that contain the direct descendant character '>' are too explicit (i.e. ... td label > strong). When jQuery UI is applied, <strong>
is no longer a child of <label>
but rather a descendant of it, thus making the selectors fail. The proposed patch simply removes the '>' part of the selectors.
We've been using this solution in several projects where we have a custom admin theme in place that utilizes jQuery UI button on checkboxes and it doesn't appear to negatively affect any module_filter functionality while it does allow us to utilize jQuery UI button on the modules list page.
Comment | File | Size | Author |
---|---|---|---|
#7 | ModulesList20130613_Snippet.png | 27.61 KB | kjv1611 |
#1 | jquery-ui-button-makes-module-filter-fail-1933384-2.patch | 1.16 KB | kaidjohnson |
Comments
Comment #1
kaidjohnson CreditAttribution: kaidjohnson commentedAnd the proposed patch...
Comment #2
joekrukoskyKaid, thanks.
I'll verify Kaid's patch in #1 corrects the vertical menu issue, in my case caused by jQuery Update.
Comment #3
timaholt CreditAttribution: timaholt commentedThe patch in #1 works for me as well, and fixes the issue.
Comment #4
kjv1611 CreditAttribution: kjv1611 commentedCan someone walk me through how to apply this patch? I don't recall for sure which module I installed, may have been jQuery Update or else another related module, but ever since, this module does not work correctly. Thanks for any sort of guidance.
Comment #5
kjv1611 CreditAttribution: kjv1611 commentedOkay, perhaps I need to go through this baby steps tutorial here:
https://drupal.org/node/620014
I was hoping I could simply find some code, and copy/paste with a text editor instead of running a script to do it. I don't mind, but I know that varies based on the way each host plan is setup.
Comment #6
kjv1611 CreditAttribution: kjv1611 commentedI applied the patch, using this tool:
https://drupal.org/project/patch_manager
Says the patch went through successfully, but I see no difference. Having same issues still.
Comment #7
kjv1611 CreditAttribution: kjv1611 commentedTo give an idea of what I'm looking at currently, here(attached image) is how the Module Filter module is showing the modules on my site. Seems part of it works, but most of it does not - it was working great prior to JQueryUpdate and possibly a couple other modules I installed which required JQueryUpdate.
Comment #8
greenSkin CreditAttribution: greenSkin commentedCommitted. Look for it in the 7.x-1.8 release.