Just upgraded from 7.x-1.0 to 7.x-2.0-beta1 to use Express checkout. When going to View Cart where you insert the Checkout with Paypal button the sidebar elements in my Marinelli theme are now appearing in the main section below the Paypal Button as oposed to in the sidebar. Looking at the produced HTML the Sidebar block is now being wrapped inside the main "siteContent" div instead of after it as before.

Heres my HTML before the upgrade

Shopping Cart
CommentFileSizeAuthor
#1 form-suffix-1928990-1.patch548 bytesjoestewart

Comments

joestewart’s picture

Status: Active » Needs review
StatusFileSize
new548 bytes

Looks like this is because #suffix already contained a closing div but was being overwritten with the Express Checkout form.

James A’s picture

Many thank #joestewart, I have tested the patch and all looks fixed.

One other question you may be able to help me with, do you know why under Store > Configuration > Checkout Settings the "Billing Information" has been placed under Disabled and can't be placed back under Checkout, gives a message saying "Billing information is locked in the code to the page and was repositioned accordingly"?

I'm not sure which upgrade has locked this, potentially not Commerce Paypal, but wanted to question the logic as I may need to know the billing information if I am creating an invoice for example. It may also be that Paypal doesn't work for all purchases (ie high value above the Paypal Limit where Bank Transfer may be used).

joestewart’s picture

thanks for reporting back your test results.

I have a test install of Commerce Kickstart that has the "Billing Information" in the Checkout pane and was able to move it from disabled to Checkout and back on another install.

James A’s picture

Thank for your reply #joestewart. I have looked into my "Billing Information" issue further and suddenly realised that during my upgrade from 7.18 to 7.19 I forgot to copy the commerce_kickstart folder under profiles so ran update on 7.19 without it.

I guess this may be causing the issue but I'll need to play a little more in order to know for certain. Copying the commerce_kickstart folder into profiles doesn't seem to help on the "Billing Information" issue.

Do you know if there's an easy way around this issue of upgrading without the commerce_kickstart folder as I've done a whole load of work on the site since then, or do I need to go back to my backup at the end of January and go from there? Once again your advice / help is greatly appreciated.

James A’s picture

Right, I fixed the original issue with my "Billing Information" not being allowed to reposition.

From store -> configuration -> checkout settings I clicked on configure next to Billing Information. Under here somehow the 'Related customer profile reference field' was showing - Select -, maybe the field had been introduced since I had done my initial setup or perhaps another change I had made reset this value without warning or maybe it simply wasn't checked for before. Anyway once I set it back to "Billing Information" I was able to save the configuration and then move my "Billing Information" out of the disabled area again.

Thankfully I now no longer get the message "Billing information is locked in the code to the page and was repositioned accordingly".

#joestewart, if you have any thoughs on how I correct the commerce_kickstart mistake, or if it's even a problem (doesn't seem to be) I mentioned in my previous post I'd be very grateful, otherwise once again thanks for your help.

torgospizza’s picture

Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

The patch in #1 worked for me. Seems like this should be high priority - a broken cart page is essentially useless in a production site.

Please consider committing this.

crispiatico’s picture

The patch in #1 aslo worked for me.

Please consider committing this.

rszrama’s picture

Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.