Commons has quite a few 'dev' versions of modules in the make file. We should encourage them to make a stable release so the commons build can be more stable.

Dev Modules (* indicates a patch is being used as well):

  • apachesolr_og
  • connector
  • custom_search
  • devel
  • entityreference
  • features*
  • flag_abuse
  • http_client
  • admin_icons
  • message*
  • message_notify
  • message_subscribe*
  • oauth
  • oauthconnector
  • quicktabs
  • radioactivity*
  • strongarm
  • timeago*
  • views
  • adaptivetheme
CommentFileSizeAuthor
#2 1908812-drupal-org-dev-make-13.patch15.44 KBjaperry

Comments

ezra-g’s picture

ezra-g commented
Title: Use releases instead of dev versions of other contrib modules » Use releases or specific hashes instead of dev versions of other contrib modules

I think we could also consider specific hashes.

japerry’s picture

japerry
Location KOMK
commented
Status: Active » Needs review
StatusFileSize
new 1908812-drupal-org-dev-make-13.patch15.44 KB

The patch below should specifically version all the modules and add hashes to dev versions that we use for modules.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Looks good to me- Committed. Thanks japerry!

http://drupalcode.org/project/commons.git/commit/e7f4d9d

ezra-g’s picture

ezra-g commented
Status: Fixed » Needs work

The nightly dev snapshot is failing with:

ERROR: The project-level attribute 'revision' on project 'apachesolr_og' is not allowed.
ERROR: The project-level attribute 'revision' on project 'custom_search' is not allowed.
ERROR: The project-level attribute 'revision' on project 'entityreference' is not allowed.
ERROR: The project-level attribute 'revision' on project 'features' is not allowed.
ERROR: The project-level attribute 'revision' on project 'admin_icons' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message_notify' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message_subscribe' is not allowed.
ERROR: The project-level attribute 'revision' on project 'oauthconnector' is not allowed.
ERROR: The project-level attribute 'revision' on project 'quicktabs' is not allowed.
ERROR: The project-level attribute 'revision' on project 'radioactivity' is not allowed.
ERROR: The drupal.org validation check failed -- see http://drupal.org/node/143219

ezra-g’s picture

ezra-g commented
Status: Needs work » Fixed

I believe the problem was that we were using the revision attribute on the project, rather than as a modifier to [download]. We also had [version] in one case where a project was being pulled from git. I missed these in my review.

I committed a followup: http://drupalcode.org/project/commons.git/commitdiff/5c2e583?hp=cbae9661...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.