Closed (fixed)
Project:
Drupal Commons
Version:
7.x-3.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
23 Feb 2013 at 00:19 UTC
Updated:
11 Jul 2013 at 13:07 UTC
Jump to comment: Most recent file
The Origins implementation of hook_form_alter() isn't called when the administrative theme is active, which is the case on this form.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1925184.commons_misc.add_palette_selection_form.patch | 874 bytes | jpontani |
| #2 | 1925184.commons_misc.add_palette_selection_form.patch | 808 bytes | jpontani |
| #2 | 1925184.commons_origins.remove_palette_selection_form.patch | 603 bytes | jpontani |
Comments
Comment #1
jpontani commentedComment #2
jpontani commentedAttached two patches for review. I moved the palette form handler to commons_misc rather than commons_origins, as commons_misc is required for Commons and will always have the form alter called regardless of which theme is selected. In the new form alter, I check to make sure that commons_origins exists in the theme registry and that it is enabled, as you can't change settings for disabled themes by default in Drupal.
Comment #3
jpontani commentedThis is the right patch for commons_misc, it checks to make sure that we're on the settings form for commons origins before adding the palette form.
Comment #4
ezra-g commentedLooks good to me.
Comment #5
jpontani commentedCommitted.
http://drupalcode.org/project/commons_origins.git/commitdiff/d7f9474
http://drupalcode.org/project/commons_misc.git/commitdiff/1330fb0
Comment #7
heyyo commentedif it's a subtheme of commons origin, we don't see the palette form, because the patch targets only the commons origin theme.
Comment #8
ezra-g commentedThanks, @heyyo. Please file a new issue since this is a different problem.