The Respondjs library has support for CSS hosted not on your site, which is super important if you use the CDN module with your site.
Can you help me figure out what steps need to be taken to make this happen?
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 1925012-11.patch | 9.1 KB | mike.davis |
| #9 | 1925012-9.patch | 8.03 KB | mike.davis |
| #4 | 1925012-4.patch | 8.18 KB | danillonunes |
Comments
Comment #1
rwinikates commentedIt seems like this module needs a preference setting for local vs x-domain styles, which would adjust which version of the JS gets written to the page, probably with inputs for what the path is, since this module can't possibly expect to know where these files end up.
Seem reasonable?
Comment #2
ruplThe official README has some CDN setup instructions, but the module is not capable of handling this right now. Seems like a useful feature, but unfortunately right now I don't have a clear-cut answer.
Changing the ticket to be a feature request. Someone can tackle this if they so desire :)
Comment #3
ruplYes, that seems reasonable. I'm assuming we'd be able to get the CDN URLs from whatever Drupal module is supplying that path. Perhaps we can offer integration with http://drupal.org/project/cdn
Right now I just don't have the bandwidth or paid use-case for solving the issue.
Comment #4
danillonunes commentedI made this patch some time ago. It needs some tests. I found that, while CDN can use more than 1 domain, but Respond.js' script only allow 1 x-domain (and it should be fixed upstream).
Comment #5
danillonunes commentedBTW, here is the issue for multiple cross-domains support in Respond.js: http://github.com/scottjehl/Respond/issues/183
Comment #6
ruplIf someone gives this an RTBC I'll totally believe you and commit it :)
Comment #7
chrisjlee commentedPatch is unapply-able. probably because of the trailing large amounts of trailing whitespace:
Comment #8
danillonunes commentedActually, I think the cause is the lack of the binary gif file. I will try to regenerate the patch later.
Comment #9
mike.davis commentedI have applied this patch to my project and this applied with out any issues and fixed the cross-domain issue that we were having. The respond.proxy.gif was missing so I added that manually by downloaded it from the github project. I also noticed that the path to the gif was incorrect so I have made some changes to correct this.
I noticed that applying the patch to a direct checkout of the project resulted in:
patching file lib/cross-domain/respond-proxy.html
patching file lib/cross-domain/respond.proxy.js
patching file respondjs.module
Hunk #1 succeeded at 57 (offset -1 lines).
Hunk #2 succeeded at 108 (offset -1 lines).
But I presume that this is due to the missing gif file (which can't be added via a patch) as the rest of the files were updated/ added fine.
I have created an updated patch which doesn't include the respond.proxy.gif and corrects that path to the gif file. The respond.proxy.gif file can be downloaded from github (https://raw.github.com/scottjehl/Respond/master/cross-domain/respond.pro...) and added to the cross-domain directory to get this to work.
Comment #10
ruplYou can definitely add binary files to a repository. I'm not sure what your settings are but it is possible and happens for me by default. Here's an issue where a person moved a ton of binary files around, maybe that will provide some info to help move this patch forward: #2200459-5: Drupal 8 version
As for me testing it.. I don't use respond.js regularly anymore and don't have any sites handy for testing that both use a CDN and respond.js. If you can get the patch to include all the assets and get another reviewer to bump to RTBC I'll happily commit it!
Comment #11
mike.davis commentedOK, looking at the git diff command and I here is an updated patch generated using the '--binary' option.
This seems to only apply when using 'git apply' rather than 'patch'.
Comment #12
mike.davis commentedstatus updated :)
Comment #13
astonvictor commentedD7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.