Backport to this issue.

CommentFileSizeAuthor
#2 drupal-replace_function_exists_with_is_callable-1924462-2.patch1.14 KBmanu manu
#1 drupal-replace_function_exists_with_is_callable-1924462-1.patch1.02 KBbfr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bfr’s picture

bfr CreditAttribution: bfr commented
Status: Active » Needs review
FileSize
drupal-replace_function_exists_with_is_callable-1924462-1.patch1.02 KB

Here's the patch.

manu manu’s picture

manu manu
Primary language French
Location Aix-en-Provence
CreditAttribution: manu manu commented
Issue summary: View changes
FileSize
drupal-replace_function_exists_with_is_callable-1924462-2.patch1.14 KB

How about using call_user_func() instead of invoking directly $batch_set['finished']()?

Let's see what the testbot says...

manu manu’s picture

manu manu
Primary language French
Location Aix-en-Provence
CreditAttribution: manu manu commented
Status: Needs review » Reviewed & tested by the community

...going on and marking as RTBC...

bfr’s picture

bfr CreditAttribution: bfr commented

call_user_func() works, but does it bring anything to the table? I know it's much slower so I don't think we should use it without a reason. Is there something I don't see?

manu manu’s picture

manu manu
Primary language French
Location Aix-en-Provence
CreditAttribution: manu manu commented

Hi @bfr,

Please let me remind me the context of this issue...

I think this is because my setup (php 5.4) was screaming with static methods, or perhaps because a problem linked to:
https://www.drupal.org/node/1924420#comment-8427835

More generaly I think this was because (at lease on some php versions) callables can't be invoked directly like that.

Or maybe that's me wich is missing something?
If you need a more precise response, i will setup a reproductible test case.

Cheers

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-replace_function_exists_with_is_callable-1924462-2.patch, failed testing.