The rich_snippets_default_preprocessor function assumes its getting passed node entity data, which isn't always the case.

There is probably a better way to do this, but for now, I've added a return if the node object isn't present inside the resultset.

CommentFileSizeAuthor
#3 1923904-3.patch2.24 KBnick_vh
#1 1923904-search-nodes-only.patch731 bytesjaperry

Comments

japerry’s picture

japerry
Location KOMK
commented
Assigned: Unassigned » japerry
Status: Active » Needs review
StatusFileSize
new 1923904-search-nodes-only.patch731 bytes

Below is a patch to check for the node object before printing node specific variables.

cpliakas’s picture

cpliakas commented

Good catch. Thanks for posting a patch, and I definitely want to explore ways to be non-node friendly. Would love to hear some ideas on how to proceed.

Chris

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1923904-3.patch2.24 KB

I don't think we should block on only node centric code. For example : http://nickveenhof.be/search/site/thesis
The first result is a file, and it still can benefit from some of the rich snippets markup if support is added to it.

Attached is a patch I'm using

cpliakas’s picture

cpliakas commented

I like this approach.

What happens when the apachesolr_get_index_key_map() returns FALSE? I want to make sure that use case is handled gracefully.

Thanks for the contribution,
Chris

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

since you have isset() in all the code that relies on the output of apachesolr_get_index_key_map, it is safe to return false.

_randy’s picture

_randy commented

Nick_vh's approach and patch looks good. Our use case with commons suffers from issues with Rich Snippets and Tika file search results. The patch provided by Nich_vh eliminates the assumption of node based result sets.

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Excellent. Thanks for testing! Marking as RTBC.

cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Committed at http://drupalcode.org/project/rich_snippets.git/commit/fad5697.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.