Add simple static caching [#1920740]

When not using any arguments the current code executes and renders the same view output for every row in the parent view. Even when the parent view has regular caching enabled this still adds a lot of unnecessary code to the critical path. The attached patch adds a simple static caching layer.

This could potentially be extended to work with arguments also (by adding a 3rd dimension to the array), but that doesn't add any value unless you are adding fields multiple times (see idea in #1920730: Provide a way to retrieve values from field based views).

Comment	File	Size	Author
#4	1920740-4.patch	2.68 KB	damiankloip
#4
	static-cache.patch	3.2 KB	Owen Barton

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

damiankloip CreditAttribution: damiankloip commented 12 March 2013 at 11:35

Status:

Needs review

» Needs work

I'm definitely not opposed to this idea!

+++ b/views_field_view_handler_field_view.incundefined
@@ -355,6 +355,8 @@ class views_field_view_handler_field_view extends views_handler_field {
+    static $cached = array();

We might as well just have this as a property on the class? Running is slightly different in that respect.