This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for file module.

Schema in place

Schema not yet in place
file.settings.yml

Files: 
CommentFileSizeAuthor
#6 comparison-file.png567.92 KBYesCT
#4 1919166-file-schema-4.patch728 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 52,355 pass(es). View
#2 1919166-file-schema-2.patch727 bytesvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 52,212 pass(es), 1 fail(s), and 0 exception(s). View
#2 1919166-diff-1-2.txt1.25 KBvijaycs85
#1 1919166-file-schema.patch545 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 50,674 pass(es). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
545 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,674 pass(es). View

Adding schema file...

vijaycs85’s picture

FileSize
1.25 KB
727 bytes
FAILED: [[SimpleTest]]: [MySQL] 52,212 pass(es), 1 fail(s), and 0 exception(s). View

Updating patch with code style from http://drupal.org/node/1905070#codestyle.

Status: Needs review » Needs work

The last submitted patch, 1919166-file-schema-2.patch, failed testing.

vijaycs85’s picture

FileSize
728 bytes
PASSED: [[SimpleTest]]: [MySQL] 52,355 pass(es). View

Label fix...

vijaycs85’s picture

Status: Needs work » Needs review
YesCT’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
567.92 KB

The schema file meets the standards in http://drupal.org/node/1905070#codestyle , looks good.

I did a manual visual comparison between the schema and the data yml, looks good.

I could not find where a form might be in the UI for description and icon, so did my best guess, which was to add a file field to a content type and then create that content.

comparison-file.png

So. rtbc.

--
only small thing I noticed was an extra blank like in the file.settings.yml

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.