I came across this issue when trying to build a module that can create entities in a modal dialog via ajax. I'm using enity_create() and entity_form() with great success for nodes, terms and users however I couldn't get a form when it came to vocabs.

I traced it through and it looks to me like entity_metadata_form_taxonomy_vocabulary() was a copy and paste of entity_metadata_form_taxonomy_term() but someone forgot to change the name of the arg and the form id.

Here's a patch.

Thanks
Josh

CommentFileSizeAuthor
#6 code_review_helper-1918644.module.test3.24 KBalexander allen
#5 issue-1918644-incorrect-form-id.patch1.14 KBalexander allen
#2 vocab_form_id.patch1.07 KBalexander allen
vocab_form_id.patch1.07 KBsonictruth

Comments

jeff h’s picture

jeff h commented

Tested and working fine here.

Any maintainers got a few minutes to roll this patch in?

alexander allen’s picture

alexander allen commented
Status: Active » Needs review
StatusFileSize
new vocab_form_id.patch1.07 KB

Hmm, the patch was not tested by Drupal. Re-uploading for testing.

Thanks for reporting and fixing this.

alexander allen’s picture

alexander allen commented

Do'h, this is for 7.x-1.0, needs to be re-rolled and re-tested for the latest.

alexander allen’s picture

alexander allen commented
Status: Needs review » Active
alexander allen’s picture

alexander allen commented
Status: Active » Needs review
StatusFileSize
new issue-1918644-incorrect-form-id.patch1.14 KB

Re-uploaded to reflect line numbers in latest version. Line numbers changed slightly (from @@ -892,11 to @@-915,11 ...). Re-roll applied cleanly for me on the 7.x-1.x dev version.

alexander allen’s picture

alexander allen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new code_review_helper-1918644.module.test3.24 KB

Tested. Changing

drupal_build_form('taxonomy_form_term', $form_state);

to 

 drupal_build_form('taxonomy_form_vocabulary', $form_state);

returns a proper taxonomy vocabulary form.

In my test, attempting to retrieve a 'taxonomy_form_term' form resulted in a Drupal error page.

Test attached.

fago’s picture

fago
Primary language German
Location Vienna
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

ops - I guess that was me ;)

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.