drush command pm-download doesn't preserve file modification time of project files [#1914470]

When project is installed with drush command pm-download file modification time of its files is not preserved because files are copied with PHP function copy() which doesn't preserve file modification time (in contrast, when project is updated with drush command pm-updatecode file modification time is preserved because files are moved).

It seems logical to preserve file modification time for drush command pm-download as well.

Comment	File	Size	Author
#1	drush-pm-download-preserve-mtime-1914470-1.patch	424 bytes	Anonymous (not verified)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 11 February 2013 at 20:24

Status:

Active

» Needs review

File	Size
drush-pm-download-preserve-mtime-1914470-1.patch	424 bytes

Here is the patch against latest 8.x-6.x-dev (which also works perfectly for 7.x-5.x) to resolve this feature request. I also removed superfluous strict type check "!== FALSE" because both copy() and touch() always return either TRUE or FALSE. Please review and commit. Thank you!

Comment #2

greg.1.anderson CreditAttribution: greg.1.anderson commented 21 March 2013 at 20:28

Status:

Needs review

» Fixed

I agree that this is correct. Committed to 8.x-6.x. Not committing to 7.x-5.x just for basic conservatism, but could potentially be committed there as well.

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 28 March 2013 at 10:28

Thanks a lot for reviewing and commiting! If it's possible, please commit this patch to 7.x-5.x because 8.x-6-x won't be released untill Drupal 8 and it's quite a long time to wait.

Also, again if it's possible for you, please review my two other patches for Drush which seem correct to me:
https://drupal.org/node/1193526#comment-7027444
https://drupal.org/node/1509936#comment-7027270

Comment #4

greg.1.anderson CreditAttribution: greg.1.anderson commented 28 March 2013 at 14:05

Version:	8.x-6.x-dev	» 7.x-5.x-dev
Status:	Fixed	» Patch (to be ported)

Actually, we are planning on releasing 8.x-6.x prior to DrupalCon Portland, and should have an RC release out shortly. Drush releases do not align with Drupal releases.

I don't use archive-dump much, and have therefore been spending my time on other issues needing attention. Hopefully someone will get to your patches soon, though. We have a lot of issues right now that could be committed with a little review time.