Implementing this hook would allow Aurora to ensure that any required Modernizr tests are included when Modernizr is rebuilt.

I'm assuming you'll want media query support. I'm also aware of TypeKit settings in the config. Is there anything else that Aurora has out of the box?

Comments

rupl’s picture

rupl
he/him
Primary language English
commented
Title: Implement hook_modernizr_info(). » Implement hook_modernizr_info() within Aurora

Changing title to be more specific since I'm about to file lots of these issues :)

Also, I looked through the codebase, is the html5shiv hidden somewhere? Would there be a way to suppress it if Modernizr is enabled, assuming it was included in the Modernizr hook?

iamcarrico’s picture

iamcarrico commented
Status: Active » Postponed

Postponing this until we can fully review the use of hook_modernizr_info() within the theme layer.

iamcarrico’s picture

iamcarrico commented
Title: Implement hook_modernizr_info() within Aurora » Implement modernizr module tests within .info file of Aurora
Status: Postponed » Active

Moving this back to active, #1914478: [meta] Provide Modernizr integration for other contrib modules.

We need a list of tests that Aurora should rely on... which might not be any due to its nature of providing very little.

Snugug’s picture

Snugug commented
Status: Active » Closed (works as designed)

Considering there is no test for box-sizing: border-box, I'd say we don't have any need for tests in Aurora.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Closed (works as designed) » Needs review

Actually there is one: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/b...

I think I'm doing this right? https://github.com/Snugug/Aurora/pull/19

iamcarrico’s picture

iamcarrico commented
Status: Needs review » Closed (fixed)

Fixed in the aurora compass plugin