Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is follow-up to #1134676: Only show fonts on the default theme.
Turning 'load fonts in all themes' off breaks font preview if admin theme != default theme; this is so in a standard install, and some users may even not realize they're using a different admin theme. Although 'load fonts in all themes' is on by default, there's still a potential for confusion. (doh, I even managed to get myself confused).
Proposed solution: add a warning if there are good reasons to believe the user is looking at a broken font preview.
Patch coming.
Comment | File | Size | Author |
---|---|---|---|
#1 | fontyourface-Missing_font_preview_potentially_confusing-1913976-1.patch | 1.7 KB | Drave Robber |
Comments
Comment #1
Drave Robber CreditAttribution: Drave Robber commentedPatch attached.
Comment #2
BarisW CreditAttribution: BarisW commentedAnother option would be to add a check in hook_preprocess_html() to see if we're on the admin page (admin/appearance/fontyourface/*) and if so; don't return.
Comment #3
Drave Robber CreditAttribution: Drave Robber commentedThen you could get sudden change in look as you go from
admin/appearance
toadmin/appearance/fontyourface
, if there are fonts with general selectors like<h2>
or<p>
.Comment #4
Drave Robber CreditAttribution: Drave Robber commentedThis is probably minor though.
Comment #5
Neslee Canil Pinto