Core Javascript Files Not Using Standard Indentation

Compatability with JSLint is not my concern. What is is that there are discrepancies amongst the .js files in terms of indentation on the main body of code. This patch addresses the fact that indentation in these files does not strictly match the Drupal JS Coding standards.

This patch changes indentation in all .js files in core/modules which were not indented properly.

And this addresses the same issues in the core/misc directory.
I did not and will not fix these problems in misc/ckeditor or misc/ui/ui since in those javascripts, the indentation problem is going to recur from the vendor.

Patches failed to apply

3: drupal-standard_javascript_indentation_misc-1913510-3.patch queued for re-testing.

modified formatting in core/misc/drupal.js

modified core/misc/drupal.js to fix indenting according to drupal standards (2 spaces). Followed the instructions on setting up phpstorm per this url: https://drupal.org/node/1962108 Also needed to modify phpstorm's javascript settings to 2 spaces.

Then I used PHPStorm's Reformat Code, but it modified a couple lines. I undid those changes and the latest patch returns nothing with git diff -w.

trying again to cleanly change the indentation on drupal.js.

That last patch is perfect for drupal.js, now on to the misc/ then modules/ folder :)

Thanks!

Cancelled patch test, it's only changing JS files.

modified the rest of the javascript files in the core/misc folder.

The last patch doesn't seem to include changes from the previous patch, can you make a single patch with all the changes at the end?

ajax.js:138–145 comment not indented properly (same issue that was in drupal.js)
tableheader.js:18,26,46,58 comment not indented properly
tableresponsive.js:136 comment not indented properly

And you missed the core/misc/dropbutton/dropbutton.js file :)

modified all js files under core/modules to use standard indentation

triggering testbot by setting to needs review.
erich_s is also going to merge the two patches, so I'm going to also cancel the testbot requests to keep them out of the test queue.

combined earlier patches numbered 10, 12 and 13. This contains all js files in core/misc and core/modules.

Sorry for the delay on this - had internet troubles. I believe patch 26 addresses all the issues. It contains all the javascript files in core/misc and core/modules. Single-line comments should all be fixed.

oh just one last issue.

Could you remove the changes made to the core/modules/tour/js/jquery.joyride-2.0.3.js file please? this is an external file and we shouldn't change it. Beside that, it's RTBC!

Here we go.

Correct interdiff ignore the last one.

And that's a wrap!

Thank you very much for the patch. Really happy to get that RTBC :D

Review all the files, all comments are indented properly. git diff -w is empty. It's all good.

Ah sorry, still a couple comments not indented

collapse.js:110
drupal.js:99
states.js:558,563,568
tabbingmanager.js:284,285

nod,
Sorry for the oversight. I need to deal with something else this morning, but I'll take care of this today. Should I start with the interdiff, apply that to the latest 8.x, make my changes then create the patch?

you can apply #30 on a clean 8.x codebase, make the changes in #33 and post the patch :)

Sounds good. Working on it now. Will have it to you in a jiffy.

40th time's a charm! Got my fingers crossed. This should be the whole kit & kaboodle.

No more comment problems, all good now!

git diff -w still empty. Only indent changes in this patch :)

EDIT:

the summary said that it uses JSLINT to check errors. But the CORE is using JSHINT.
Please add "indent" option to .jshintrc :)

$ jshint core
core\modules\edit\js\editors\formEditor.js: line 74, col 43, Expected '}' to have an indentation at 9 instead at 43.
core\modules\views_ui\js\views-admin.js: line 160, col 6, Expected '}' to have an indentation at 3 instead at 6.
core\modules\views_ui\js\views-admin.js: line 758, col 6, Expected '}' to have an indentation at 3 instead at 6.

3 errors

Here's the same patch as 40, but with indent: 2 added to .jshintrc

I'm trying to make the changes in #42, but the first one sounds like I should change it like this, however that'll result in git diff -w producing a result (although not sure why since it's only a line break I added):

--- a/core/modules/edit/js/editors/formEditor.js
+++ b/core/modules/edit/js/editors/formEditor.js
@@ -71,7 +71,8 @@ Drupal.edit.editors.form = Drupal.edit.EditorView.extend({
// Render form container.
var $formContainer = this.$formContainer = $(Drupal.theme('editFormContainer', {
id: id,
- loadingMsg: Drupal.t('Loading…')}
+ loadingMsg: Drupal.t('Loading…')
+ }
));
$formContainer
.find('.edit-form')

@erich_s,

Yeah, it would produces visible difference. "-w" option only skips the spaces checking.

Here's another patch that addresses Droplets comments. Also, it contains NO changes to the .jshintrc file - I misunderstood Droplet's comment on that.

Let's try this again. This version has all the js files, think the issues pointed out by Droplet and nod have been addressed. .jshintrc has been modified to include indent:2

All right, jshint core/ returns no errors.

Attached the output of git diff -w

x2 RTBC. :)

Committed 2d476a5 and pushed to 8.x. Thanks!

change notice at: https://drupal.org/node/2183065

Should someone have a problem with rerolling an existing patch because of this change, feel free to ping me and I'll help reroll it.