While installing Drupal head my site directory permission were not set correctly.

Once fixing the issue, I notice that the GUI did not offer a button to reload the page.

So I added a link, with the help of webchick, to reload the page.

CommentFileSizeAuthor
#4 reloadinstall.patch1.69 KBxmacinfo
#2 reload_install_modules.png24.18 KBadd1sun
reloadinstall.patch963 bytesxmacinfo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

add1sun’s picture

add1sun CreditAttribution: add1sun commented
FileSize
reload_install_modules.png24.18 KB

I recreated the error (on my test site, I changed the ownership of sites/default to root and made sure it was not writable) and the patch gave me the "reload page" link as expected.

However as I was trying different things to get errors on the install page one thing I did was add a non-existent module to the default profile (e.g. edit profiles/default/default.profile and added 'boo' to the list of modules.) When I got the "required modules are missing" error, it already has a "try again" link that uses different text from this patch. Also, the "reload page" that this patch adds was between the set message box and the "reload page" link which is quite odd looking. See the attached screenshot for a clearer picture. ;-)

add1sun’s picture

add1sun CreditAttribution: add1sun commented
Status: Needs review » Needs work

oops, cnw

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
CreditAttribution: xmacinfo commented
Status: Needs work » Needs review
FileSize
reloadinstall.patch1.69 KB

Thanks add1sun for the comments and review.

I'm including a patch that fixes both of these issues.

add1sun’s picture

add1sun CreditAttribution: add1sun commented
Status: Needs review » Needs work

Awesome! Now it gives just one standardized "try again" message for both the writable sites/default and the required modules error. Looks good to me.

add1sun’s picture

add1sun CreditAttribution: add1sun commented
Status: Needs work » Needs review

Son of a... stupid cnw. This is definitely for review and just needs another review for RTBC.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

OK, new contributors need some encouragement so I have reviewed it and like it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Woohoo! :) Way to go, xmacinfo!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks. Added a paragraph wrapper around the reload link text, and committed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.