Language Field gets "Stuck" after Title

So the issue here appears to be with the way the language field information is stored. The two naming conventions that look to be in dispute are language and langcode. I'm willing to bet by correcting the naming conventions of the machine name this issue will be solved.

In the cache_field table the language field weight is being stored successfully in the extra field bundle field_info:bundle_extra:node:article. However, when the language select field is rendered on the node form in node/add/article, it's named langcode.

I traced the issue back a ways through the field.module, and isolated the problem to what is returned from field_info_extra_fields() in _field_extra_fields_pre_render(). $extra_fields is populated incorrectly with the name 'language,' while $elements contains the name 'langcode.' This discrepancy wiIl prevent $elements['langcode'] from being updated correctly. I added a simple conditional below to demonstrate the issue:

// in field.module, line 764
function _field_extra_fields_pre_render($elements) {
  $entity_type = $elements['#entity_type'];
  $bundle = $elements['#bundle'];

  $extra_fields = field_info_extra_fields($entity_type, $bundle, 'form');
  foreach ($extra_fields as $name => $settings) {
    if (isset($elements[$name])) {
      $elements[$name]['#weight'] = $settings['weight'];
    }
    // simple conditional demonstration to set the weight correctly
    if ($name == 'language') {
      $elements['langcode']['#weight'] = $settings['weight'];
    }
  }

  return $elements;
}

With that conditional added, the weight is correctly rendered on the node edit form.

I'm not entirely familiar enough with the larger scope of why the language module naming conventions are what they are, so I'll let someone else work through this a bit more. Hope this information helps however.

Confirmed this is still an issue.

This is probably more a field api problem then language, so changing the component.

This fixes it

fixing tests

Djeez

This is so confusing! I had to dig a bit in EntityFormController and the fix is correct. RTBC hoping that the tests will pass this time.

Patch no longer applies.

Rerolled.

Wow, what a fantastic bug report! :) Glad the fix was so easy.

Committed and pushed to 8.x. Thanks!

Updated issue summary.