Active
Project:
JavaScript Tabs
Version:
7.x-1.1
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Feb 2013 at 17:54 UTC
Updated:
4 Jul 2013 at 07:08 UTC
I'm sorry to write that the "view" and "edit" buttons are still displayed and the javascript tabs are not...
Comments
Comment #1
ken hawkins commentedThis is probably due to your theme overriding the tabs already; from the readme:
Would probably be helpful to others if this note were added to the module page, as well as a known-compatible theme were listed -- so that users unsure if there is a problem could try the theme.
Comment #2
webmestre commentedThe admin used theme is SEVEN.
It's a pity not to use your module on Seven because I guess it could be one of the most popular admin themes...
Comment #3
Sunlight Studios commented@Ken Hawkins: thanks for the suggestion, that note is now added to the module page.
The module takes its menu items directly from Drupal's tab arrays, so if a theme has modified their structure, there is no way for the module to guess where to find them.
@webmestre: you're right, Seven is popular & you've given me an idea... The only way to integrate JavaScript Tabs into a theme that already modifies the tabs would be to write it bespoke. Perhaps I could hard-code support for certain themes in, or even use a sub-module plugin type system.... I'll have a think on it.
Setting this to "feature request" as the module is actually behaving as expected.
Comment #4
Sunlight Studios commented*also changing the title, should have done that in my last post, oops*
Comment #5
ken hawkins commented@sunlight
I like the sound of the module being able to adapt to non-standard themes. You might also consider expanding the documentation so theme developers and site builders can adapt to their code to this module.
A first crack:
Comment #6
deanflory commentedHere is the header code for AdaptiveTheme custom subtheme:
page--full-width-wrappers.tpl.php
page.tpl.php
When I changed out this bit:
With this, it worked perfectly! Thanks for the tip!
So, what about secondary tabs? How do I get those to work as submenus in Javascript Tabs? I haven't test yet, but I'm guessing since they were not covered in my change above, they therefore are not included.
Comment #7
deanflory commentedFYI, I also had to change the z-index to something higher to make sure the cog button/trigger and the menu were above page content.