Comments

japerry’s picture

StatusFileSize
new10.37 KB

First patch, the dev file for drupal-org.make

japerry’s picture

Note ^^ the above file should NOT be rolled into the profile... and of course like an idiot, I did it anyway ;-) reverted.

Below is a bash script that will build a profile for you and setup symlinks so your repos can be consistent as you blow away the build directory.

It needs a build path. the structure of the command is like this:
chmod +x ./build_distro.sh (only need to do this once)
./build_distro.sh build ~/Sites/commons

/ BUILD_PATH = ~/Sites/commons
/ commons_profile <== will check out from git if it doesn't exist
/ repos <== will create directory and move commons projects into this folder and symlink to publish
/ publish <== contains the drupal site build

And you should now have a working copy with repos removed from the build. Every subsequent build you use with this script should blow away the commons modules and re-symlink it to your repos folder.

Also you can run ./build_distro.sh pull ~/Sites/commons if you wish to update all the repos at once.

build_distro can be found here:
http://drupalcode.org/project/commons.git/blob/37965b90a182f578f596f255f...

ezra-g’s picture

Attempting to run the script I get:

Wally2: ./build_distro.sh build ./test1
Cloning into 'commons_profile'...
remote: Counting objects: 2330, done.
remote: Compressing objects: 100% (2054/2054), done.
remote: Total 2330 (delta 1445), reused 442 (delta 193)
Receiving objects: 100% (2330/2330), 3.55 MiB | 206 KiB/s, done.
Resolving deltas: 100% (1445/1445), done.
./build_distro.sh: line 18: cd: ./test1: No such file or directory
fatal: destination path 'commons_profile' already exists and is not an empty directory.
./build_distro.sh: line 18: cd: ./test1: No such file or directory
fatal: destination path 'commons_profile' already exists and is not an empty directory.
./build_distro.sh: line 18: cd: ./test1: No such file or directory
fatal: destination path 'commons_profile' already exists and is not an empty directory.

The errors repeat several more times.

ezra-g’s picture

#1 no longer applies.

ezra-g’s picture

StatusFileSize
new10.79 KB

Here's an attempt at a re-roll.

ezra-g’s picture

ezra-g’s picture

StatusFileSize
new12.06 KB

Updating the patch to pull the Message* modules from git: http://drupalcode.org/project/commons.git/commit/8d9fa1b.

This originally became necessary at #1867190: Audit Features for cruft & overrides on fresh install - Let's consider reverting this change once http://drupal.org/node/1915364#comment-7067302 is applied.

ezra-g’s picture

I reverted back to patch #5.

ezra-g’s picture

japerry’s picture

StatusFileSize
new10.5 KB

This patch will work with the new 3.0 release

japerry’s picture

StatusFileSize
new15.55 KB

The following patch is a heads up for stabilizing the 3.0 branch of commons. We don't want modules in our distribution to update themselves without us testing it!

japerry’s picture

StatusFileSize
new15.56 KB

yah that patch had a typo in it. I wish we could exactly test this without needing to fetch the patch =P

japerry’s picture

StatusFileSize
new15.44 KB

okay last revision. I should really stop now. Fixed an issue with referencing a newer Ctools than we should have.

ezra-g’s picture

#10 (currently in the -dev make file) no longer applies.

ezra-g’s picture

Title:Document the commons development process» Provide a -dev version of the Commons make file
Status:Active» Needs work

Re-titling to what seems to be the focus of the issue.

ezra-g’s picture

Status:Needs work» Needs review
StatusFileSize
new8.89 KB

Quick stab at re-rolling #10.

japerry’s picture

StatusFileSize
new9.39 KB

Opps the last role did not include the theme! Re-rolled to include the theme.

Verified that we're using the theme, and that we aren't changing any other module versions.

japerry’s picture

StatusFileSize
new1.33 KB

test updates for metatag, og, votingapi

ezra-g’s picture

Status:Needs review» Fixed

I think we can mark this as fixed and use this issue to track updates to the patch/make file here.

quiethero’s picture

This Documentation Group seems to be the most equipped to help me with my problem with DC and Drupal 7.22 Installation. I have posted my inquiry but no responses yet.

Issue: This is my 5th iteration with trying to effectively install Commons and Drupal 7.22. (Exhausted) Every time I try to use it after a few modules are installed I get the same message and cannot get out of it without totally starting the site from scratch. Even my backups don't load.

Also, I found 4 instances of field.info.inc and know that the problem therein lay. Could this be correct?

/public_html/sites/all/modules/commons/modules/field/field.info.inc
/public_html/modules/field/field.info.inc
/public_html/sites/all/modules/commons/profiles/commons/modules/contrib/entity/modules/field.info.inc
/public_html/sites/all/modules/entity/modules/field.info.inc

"Seems like each one of them are declaring something different to each other and the system"

Errors Messages:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'module' cannot be null: INSERT INTO {role_permission} (rid, permission, module) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => 2 [:db_insert_placeholder_1] => create event registration [:db_insert_placeholder_2] => ) in user_role_grant_permissions() (line 3076 of /home/mysite/public_html/modules/user/user.module).

/public_html/sites/all/modules/commons/modules/field/field.info.inc

Fatal error: Cannot redeclare class DrupalQueue in /home/warpro/public_html/modules/system/system.queue.inc on line 60

Line 60

class DrupalQueue {

I would rather use the "new" DC as designed because it looks awesome and has great promise but I am just spinning my wheels from install to install. Right now, my website, all functions, Ctools all green. Not one error on installation.

Now... I am having to load DC via my server because its too large for the 8 MB limit (11 MB) directly to /sites/all/modules and extract there or should I ftp from filezilla or something like that?

I need DCommons but I am stuck at this point. All dressed up "Green Lights on everything" and can't enable Commons. I can load it; but once loaded the damage is done (Those darn complicated dependencies).

Any suggestions?

Please post or email me with your suggestion(s)

Thank you...

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

japerry’s picture

StatusFileSize
new4.3 KB

I have re-written the build script to automatically grab the git repos and build the regular repo. That way we don't need the build-commons-dev make file anymore.

japerry’s picture

Status:Closed (fixed)» Needs review

marking needs review

ezra-g’s picture

StatusFileSize
new9.69 KB

Here's a re-roll of #17, which no longer applies.

This is updated in build-commons-dev.make with http://drupalcode.org/project/commons.git/commit/53c88ae.

RobKoberg’s picture

Version:» 7.x-3.2

Using the latest dev make file, after submitting "Enter Homepage welcome text", I get these Notices:

    Notice: Undefined offset: 4 in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in commons_activity_streams_node_insert() (line 41 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_activity_streams/commons_activity_streams.module).
    Notice: Trying to get property of non-object in commons_groups_first_contribution() (line 776 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_groups/commons_groups.module).
    Notice: Trying to get property of non-object in commons_notify_node_insert() (line 36 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_notify/commons_notify.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).

After submitting the create Engineering group, I get these notices:

    Notice: Undefined offset: 4 in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3604 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3605 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Undefined offset: 4 in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).
    Notice: Trying to get property of non-object in user_node_load() (line 3606 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/modules/user/user.module).

Then, hitting the Boston group page, I get about 100 of these Notices (I believe this is because I am using php5.4, but still...):

Notice: Array to string conversion in panels_cache_object->cache() (line 178 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/panels/includes/plugins.inc).

davidhunter’s picture

Same issue as RobKoberg.

Installed XAMPP on Windows 7 :
Apache 2.4.3
MySQL 5.5.27
PHP 5.4.7

Fresh install, added content using Group content type.

Creates group with success :
Group Group Content Type has been created.
Thanks for your group submission! This group has entered the moderation queue and will be reviewed shortly.
- See more at: http://localhost/commons/groups/group-content-type#sthash.tA8WZMX1.dpuf

Then prints out 100 lines of this Notice :
Notice: Array to string conversion in panels_cache_object->cache() (line 183 of C:\xampp\htdocs\commons\profiles\commons\modules\contrib\panels\includes\plugins.inc). - See more at: http://localhost/commons/groups/group-content-type#sthash.tA8WZMX1.dpuf

ezra-g’s picture

As a stopgap to #1983606: Move some of the Commons_* modules into the Commons distro repo, let's commit #24 to the build-commons.make file so that folks can help test the upgrade path to Commons 7.x-3.3 using the nightly development snapshot. We can always roll this commit back after the release if necessary.

ezra-g’s picture

Title:Provide a -dev version of the Commons make file» Provide a -dev version of the Commons make file, stopgap for nightly development snapshot
Status:Needs review» Fixed

#24 is committed. Soon, the dev snapshot will re-roll and be representative. Hooray!
http://drupalcode.org/project/commons.git/commitdiff/71a4dcb?hp=69add882...

ezra-g’s picture

Status:Fixed» Needs work

Actually, this isn't quite resolved: The Drupal.org packager will only detect changes in nightly dev snapshots of upstream projects - It won't detect changes if we reference the git URL. I'll update to point to dev snapshots.

ezra-g’s picture

Status:Needs work» Fixed
ezra-g’s picture

ezra-g’s picture

An additional followup to fix the broken build: http://drupalcode.org/project/commons.git/commit/7bfcf04.

RobKoberg’s picture

using on an existing commons base clone:

$ git pull
...
2 files changed, 32 insertions(+), 3 deletions(-)

then:
$ drush make --no-cache --working-copy build-commons-dev.make ../commons-7.x-3.x-dev

results in ../commons-7.x-3.x-dev not existing and no errors.

Is the nightly working yet? I need to put the current state of my project up on Acquia's cloud so decision can makers can see where we are at. Trying to get them to hold out until 3.3. is released but that is not working...

ezra-g’s picture

You can use build-commons.make (no -dev) or the dev snapshot tarball which is now packaged. Please let us know if that doesn't work for you.

RobKoberg’s picture

Great, thanks for quick response. I will go with the tarball. I assume that build-commons.make will make 3.2, right? (I need 3.3)

ezra-g’s picture

build-commons.make currently points to the dev snapshot.

dstol’s picture

Version:7.x-3.2» 7.x-3.x-dev
Status:Fixed» Needs review
StatusFileSize
new11.2 KB

Patch in #24 no longer applies and breaks the -dev.make build.

ezra-g’s picture

Status:Needs review» Fixed

build-commons.make supersedes build-commons-dev.make until 3.3 is released.

ezra-g’s picture

Status:Fixed» Needs work

For now, folks can use build-commons.make instead of build-commons-dev.make.
However, we should make build-commons-dev.make identical to the current build-commons.make except that -dev should grab the Commons project from git, rather than the dev snapshot.

ezra-g’s picture

Status:Needs work» Fixed

I made the change proposed in #39: http://drupalcode.org/project/commons.git/commit/b8b49fb. I believe this is fixed.

RobKoberg’s picture

Still not working.

$ drush make --no-cache --working-copy build-commons-dev.make ../commons-dev

nothing is deposited at ../commons-dev, and:

$ drush make --no-cache --working-copy build-commons.make ../commons-dev
drupal-7.22 downloaded.                                                                                                                                              [ok]
drupal patched with spark-install-1780598-5.patch.                                                                                                                   [ok]
drupal patched with 1074108-skip-profile-16-7.x-do-not-test.patch.                                                                                                   [ok]
drupal patched with allow_change_system-requirements-1772316-4.patch.                                                                                                [ok]
drupal patched with install_profile_requirements_on_install.patch.                                                                                                   [ok]
drupal patched with 1664602-1.patch.                                                                                                                                 [ok]
Generated PATCHES.txt file for drupal                                                                                                                                [ok]
Unable to download commons-7.x-3.x-dev.tar.gz?date=1374885900 to /tmp/drush_tmp_1375373465_51fa88998436b from                                                        [error]
http://ftp.drupal.org/files/projects/commons-7.x-3.x-dev.tar.gz?date=1374885900
ezra-g’s picture

I made an additional progress commit http://drupalcode.org/project/commons.git/commit/ec1ab23.

@RobKoberg, let's dig into the output you provided.

Unable to download commons-7.x-3.x-dev.tar.gz?

That means that we have a recursive failure, since build-commons.make attempts to download the nightly dev tarball, which we're troubleshooting at #2054133: Nightly dev snapshot is days behind latest Commons commits..

In the meantime, you should be able to use build-commons-dev.make.

RobKoberg’s picture

I did try the dev make file. I just tried again. I did a git pull and saw more updates come down. However, it still results in nothing being built there are errors:

File commons_origins-7.x-3.x-dev.tar.gz?date=1375229187 is corrupt (wrong md5 checksum).                                                                             [error]
Unable to patch message_subscribe with 1828184-remove-email-default-notifier-31.patch.                                                                               [error]
ezra-g’s picture

Did you git pull first?

RobKoberg’s picture

" I did a git pull and saw more updates come down."

Before each make attempt I did a git pull.

RobKoberg’s picture

Just did another git pull and saw more changes come down. Still not being built. Getting error:

File commons_origins-7.x-3.x-dev.tar.gz?date=1375229187 is corrupt (wrong md5 checksum).                                                                             [error]

Looks like the message_subscribe patch error was fixed.

RobKoberg’s picture

So is this simply a matter of regenerating the checksum? It seems that the build will always fail if there is an error. Is there a way to have the make stop on error? (a quick search did not turn anything up)

dstol’s picture

If you were to comment out lines 71-78 of wget.inc linked below and drush make should work again.

http://drupalcode.org/project/drush.git/blob/cea2ca02d09a2dd2241b840d750...

It's a good stopgap until #2038077: New project release for dev releases doesn't get published is resolved.

ezra-g’s picture

Thanks, dstol. I've also had success with drush make --force-complete --ignore-checksums commons-profile/build-commons-dev.make ./commons-builds/test-10 --no-cache .

RobKoberg’s picture

just tried again (git pull and then drush make) and it is working as expected.

ezra-g’s picture

Great - thanks for the update.

ezra-g’s picture

Status:Fixed» Needs work

The Commons* modules are being pulled from nightly dev snapshots with build-commons-dev.make. That's tine for the drupal.org packager but we should be using git clone URLs so that we can easily commit to the commons* projects.

ezra-g’s picture

StatusFileSize
new11.23 KB

Here's a revised patch per #52, applied in build-commons-dev.make per http://drupalcode.org/project/commons.git/commit/39a9878.

ezra-g’s picture

StatusFileSize
new9.83 KB

Re-roll of #53 which no longer applied.

ezra-g’s picture

Status:Needs work» Needs review
StatusFileSize
new9.9 KB

This is re-rolled and committed with http://drupalcode.org/project/commons.git/commit/1dc8caa .

ezra-g’s picture

StatusFileSize
new9.9 KB

Revised patch since 55 no longer applies. Revised with http://drupalcode.org/project/commons.git/commit/9bc717e .

ezra-g’s picture

Status:Needs review» Needs work

Unfortunately, #56 also doesn't apply.

ezra-g’s picture

Status:Needs work» Needs review
StatusFileSize
new10.15 KB
ezra-g’s picture

ezra-g’s picture

jrbeeman’s picture

StatusFileSize
new9.69 KB

Re-rolled patch against latest dev.

dstol’s picture

rb2k’s picture

Current tarball builds fail btw:

Checked out branch 7.x-3.x. [20.42 sec, 9.29 MB]                            [ok]
can't find file to patch at input line 5                                [notice]
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/drupal-org.make b/drupal-org.make
|index 212c86b..ff9ebbc 100644
|--- a/drupal-org.make
|+++ b/drupal-org.make
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored [21.22 sec, 9.3 MB]
Unable to patch commons with 1908812-commons-make-dev-60.patch.          [error]
[21.22 sec, 9.58 MB]
ezra-g’s picture

Following #1983606: Move some of the Commons_* modules into the Commons distro repo, I've removed build-commons-dev.make and updated .travis.yml.

We can now use build-commons.make for both stable and dev builds. For dev, checkout the tip of 7.x-3.x. For stable, checkout the desired stable tag.

http://drupalcode.org/project/commons.git/commitdiff/4e78bb2f52eb9350d39...

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.