Why is the "When text analysis is unsure" and "When text analysis identifies spam" not provided for webforms when using the text analysis option? I need middle ground as I do not want to permanently display a "captcha" or flat out deny a submission with "Your submission has triggered the spam filter and will not be accepted".

cheers

Files: 
CommentFileSizeAuthor
#6 0001-1906978-by-sun-Fixed-text-analysis-does-not-always-a.patch1.96 KBsun
PASSED: [[SimpleTest]]: [MySQL] 4,449 pass(es). View
#4 0001-1906978-by-sun-Fixed-text-analysis-does-not-always-a.patch994 bytessun
FAILED: [[SimpleTest]]: [MySQL] 4,447 pass(es), 2 fail(s), and 0 exception(s). View
#1 mollom.binary-always.1.patch734 bytessun
PASSED: [[SimpleTest]]: [MySQL] 5,029 pass(es). View

Comments

sun’s picture

Status: Active » Needs review
FileSize
734 bytes
PASSED: [[SimpleTest]]: [MySQL] 5,029 pass(es). View

Webform submissions do not have a "publishing status", which inherently means that spam posts cannot be "retained as unpublished".

However, you're right in that it should be possible to use the "binary" mode for text analysis; i.e., preventing a "unsure" response and CAPTCHA with text analysis.

It looks like we simply forgot to remove the code that force-disables it :) It even states that it only applied to earlier features ;)

sun’s picture

Version: 7.x-2.4 » 7.x-2.x-dev
sun’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Committed and pushed to 7.x-2.x.

sun’s picture

Status: Patch (to be ported) » Needs review
FileSize
994 bytes
FAILED: [[SimpleTest]]: [MySQL] 4,447 pass(es), 2 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 0001-1906978-by-sun-Fixed-text-analysis-does-not-always-a.patch, failed testing.

sun’s picture

Status: Needs work » Needs review
FileSize
1.96 KB
PASSED: [[SimpleTest]]: [MySQL] 4,449 pass(es). View

Oh. Sorry, those tests are bogus.

sun’s picture

Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4f3bd95 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1906978 by sun: Fixed text analysis does not always allow for binary...

  • Commit 4f3bd95 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1906978 by sun: Fixed text analysis does not always allow for binary...