node and comment links use the "Translations" text.
But, we want parity with what admin/content and the like listings are doing now. Those dropbuttons all use "action" keywords: 'view', 'edit', 'translate'.
On the other hand, on nodes we also have "revisions" tab, which is a noun.

Proposed resolution

Unify dropbutton use of translate/translations wording in links

Remaining tasks

find all the locations that use translate/translations
decide if it should be translate or translations

User interface changes

No new UI patterns, just being consistant with wording

API changes

No API changes.

Original report by @webchick and @plach

Follow up for #30-#34 #1896268-30: Add Views integration for translation_entity

+  public function render_link(EntityInterface $entity, \stdClass $values) {
+    if (translation_entity_translate_access($entity)) {
+      $text = !empty($this->options['text']) ? $this->options['text'] : t('view');
This is a link to node/1/translations and the like, not node/1/view. So it should not be labeled 'view.' :)
[...] (renamed to 'translate')
Members fund testing for the Drupal project. Drupal Association Learn more


shnark’s picture

download and install drupal 8.
create content
under extend, enable content translation
add a couple languages, in admin/config/regional/language
enable translation in admin/config/regional/content-language by checking the checkbox for content and then article. and save.
go to content, click dropbotton:

I made a change to my content, and save revision:

I made a comment
I went to menu, configuration, content language settings, and enabled comment translations.
reload the content that you created
Click translation link, beneath the comment

shnark’s picture

48.95 KB

The first dropbotton says translate, but it takes you to a page that says "translations of Content", and doesn't actually translate.
The other places that I found that said translations, are all used correctly, taking you to lists of translations.

shnark’s picture

I think the the dropbotton at Menu >> Content, or admin/content, should be changed to translations, instead of translate.

rachel_norfolk’s picture

Hmm - after following the instructions up to the first screenshot with today's 8.x branch, I've just received a PHP error, as attached, so can't follow through...
screenshot of php error

environment: Mac, Acquia Dev Desktop 7.19.18, Safari

YesCT’s picture

129.96 KB

@rachellawson Thanks for taking a look at this.

I went through the steps too just now with a fresh git pull on the 8.x branch. And I'm not able to reproduce that error.


Would you try some of the things in this post about reproducing:

edrupal’s picture

I was able to recreate the issue taking the following steps:

  1. Install drupal 8 with standard profile.
  2. In the Extend area (/admin/modules), enable the Content Translation and Language modules in the Multilingual section.
  3. In the configuration area for Content language settings (admin/config/regional/content-language), tick the 'Content' checkbox.
  4. From the Content table that is now displayed, tick 'Basic page' and 'Body'.
  5. Create a Basic page.
  6. Go to the content list page (admin/content).
  7. Click on the 'Edit' drop down next to the newly created content to see the 'Translate' option.

Translate/Translation issue screenshot

YesCT’s picture

note, the property error found in #4 is probably this unrelated issue: #1938384: "Undefined property" error only after adding translations to existing content.

pixelite’s picture

Status: Active » Needs review
2.27 KB
PASSED: [[SimpleTest]]: [MySQL] 55,927 pass(es). View
61.31 KB

Updated the wording to 'Translations' in the operations column of the node, comments, taxonomy term, and user admin UI.

For example, in the node admin UI:
Translations wording in node admin UI

Attaching a patch with this change.

sahain’s picture

Assigned: Unassigned » sahain
sahain’s picture

Assigned: sahain » Unassigned
sahain’s picture

Applied latest patch and reviewed visually. Changes look good.

Gábor Hojtsy’s picture

Issue tags: +Needs usability review

Hm, this is an interesting one :) I personally believe the tab and dropdown would maybe better be "Translate" as in an active verb. I do see how the tab only leads to a list of translations which *then* lets you translate from another action there. So maybe this is not 100% correct, but I see it as parallel to the experince of "Edit", etc. While "Revisions" does list revisions as well (alike Translations listing translations), it is not the 80% use case to *act* on revisions on that tab, while it is *absolutely* the 80% use case to act on translations on this page.

Gábor Hojtsy’s picture

Issue tags: -Needs usability review

Also the config translation module proposed for core at #1952394: Add configuration translation user interface module in core (also uses "Translate" consistently everywhere. Not saying that is any proof, because it may be the most underused Drupal 8 module :D

Gábor Hojtsy’s picture

Issue tags: +Needs usability review
Schnitzel’s picture

Discussed with YesCT and Gabor, we all agreed that we should use "Translate", as this is the first action a User want's to do when there is no translation yet. And even it shows you a Table of all translations, so "Translations" would be super correct, we think the Verb ist still better.

chrishks’s picture

Status: Needs review » Closed (fixed)
Gábor Hojtsy’s picture

Status: Closed (fixed) » Needs work

As per #5, the Translations tab is still there, it should now be Translate. Issue is not fixed.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
4.75 KB
PASSED: [[SimpleTest]]: [MySQL] 56,597 pass(es). View

Here is a quick patch to change as discussed above.

YesCT’s picture

this looks good. did not try it manually yet. also did not grep for any remaining 'Translations' ...

YesCT’s picture

I tried this manually and noticed the comment link was still translations.


then I did a grep.

here is the grep (note to self, you could have grepped for inside of t()).

564 $ grep -Ri "\'translations\'" * 2>&1 | grep -v denied | grep -v "\[\'translations\'\]"
core/includes/    'translations' => array(),
core/modules/comment/comment.module:      'title' => t('translations'),
core/modules/locale/locale.module:    'translations' => array(

this changes the link for comment. the other two are items in an array which are fine.

YesCT’s picture

I noticed that the body of the comment seems out of order, occurring before the subject and author name.
A search needs to be done to see if an issue exists for that, and if not, an issue opened.

this has nothing to do with this issue and is not blocking this.

YesCT’s picture

662 bytes
5.4 KB
PASSED: [[SimpleTest]]: [MySQL] 55,824 pass(es). View

sorry, here are is the patch.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Looks great!

Gábor Hojtsy’s picture

Priority: Minor » Normal
Gábor Hojtsy’s picture

Issue tags: +sprint, +language-content
YesCT’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, unify-translations-wording-1899486-20.patch, failed testing.

YesCT’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +D8MI, +sprint, +language-content
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Passes well.

Gábor Hojtsy’s picture

Assigned: Unassigned » jhodgdon
jhodgdon’s picture

Assigned: jhodgdon » Unassigned

Did you just want me to review this? I don't see any problems, looks fine.

But I don't normally commit patches for UI text (I'm no usability expert), so I'll un-assign this one. :)

Gábor Hojtsy’s picture

Assigned: Unassigned » jhodgdon

Back to @jhodgdon after @catch verified she would be fine to commit UI element text changes like this.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks all! Committed to 8.x.

Gábor Hojtsy’s picture

Issue tags: -sprint

Woot, thanks!

Gábor Hojtsy’s picture

Component: translation_entity.module » content_translation.module

Automatically closed -- issue fixed for 2 weeks with no activity.