Problem/Motivation

WebTestBase::drupalLogin() uses $user as the user account to log in within the child environment. Usually, $user is reserved for the currently logged in user global.

Proposed resolution

Rename $user to $account within WebTestBase::drupalLogin().

Files: 
CommentFileSizeAuthor
#4 1898314-D7-reanme.patch1.37 KBdroplet
PASSED: [[SimpleTest]]: [MySQL] 39,809 pass(es). View
#1 1898314.patch1.56 KBdroplet
PASSED: [[SimpleTest]]: [MySQL] 49,386 pass(es). View

Comments

droplet’s picture

Status: Active » Needs review
FileSize
1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 49,386 pass(es). View
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

RTBC if it comes back green.

webchick’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks. This actually caused a bunch of confusion in a recent review, so glad to see this fixed.

Committed and pushed to 8.x. Back to 7.x for backport.

droplet’s picture

Status: Patch (to be ported) » Needs review
FileSize
1.37 KB
PASSED: [[SimpleTest]]: [MySQL] 39,809 pass(es). View
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Let's do it! :-)

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.