Markers with different icons

Thanks pivica for your help. I also have a pile of drupal work to do, so I know making precious time available...

Currently I installed it only on two D6 sites. But more to come in D5, D6 and D7. And I go to use it in some very old non-drupal sites.
I will patch it back for myself to D5. If you / someone needs the D5 version I am willing to publish this one (after I got it ready).

I am going to test it as soon as possible.
Thanks pivica.

Hello pivica,
I am sorry, but it doesn't work in D6.
Step 1
The first problem I got with "file_create_url(drupal_get_path('module', 'gmap3_tools') . '/images/dgreen.png')".
Since no own icon was shown I displayed the resulting name.
Since I have several sites on the same hosting this resulted in:
http://example.com/sites/example.com/files/sites/all/modules/gmap3_tools...
where the real path is:
http://example.com/sites/all/modules/gmap3_tools/images/dgreen.png
So it seems file_create_url() has a problem.

Second problem: the requested icon is not shown, the default icon does show.

Step 2
I installed the module without patches in a D7 site and asked for the "gmap3_tools/example" page. Result OK.
Then I patched this version, added some icons and changed the iconnames in the module file. Then I asked for the "gmap3_tools/example" page again. Result example 3 with the default red icons.

Step 3
Next I commented out this line in markerOptions:
'shadow' => file_create_url(drupal_get_path('module', 'gmap3_tools') . '/images/druplicon-shadow.png'),
Then the the "gmap3_tools/example" page resulted in displaying my icons. ==> OK

Step 4
I went back to the D6 site and added to my own map the lines:
'markerOptions' => array(
// Set custom shadow for all icons.
// 'shadow' => file_create_url(drupal_get_path('module', 'gmap3_tools') . '/images/druplicon-shadow.png'),
),
with no success: the markers kept showing the default icons.

Step 5
I commented out in the module file (like in step 3 but now in D6):
'shadow' => file_create_url(drupal_get_path('module', 'gmap3_tools') . '/images/druplicon-shadow.png'),
The "gmap3_tools/example" page still only presents the default icons.

The D6 problem definitely is in the file_create_url() function. I removed the call to file_create_url() and now the icon is showing in one of two sites in my own map.
I used exactly the same map definition en module files in both sites. I have to think why the result is different on both D6 sites: site 1: the default red icon, site 2: an orange icon.

The example 3 of the module shows another result:
site 1: 3 red icons, site 2: only 1 red icon, no more icons.

These are todays results.

When I look in the HTML I see in the D7 jQuery.extend part:
"markerOptions":{"icon":"http:\/\/example.com\/sites\/all\/modules\/gmap3_tools\/images\/dgreen.png"}
where in the D6 no backslashes appear.
Can this be the problem?

Hello pivica,

Google's deadline to move over to maps v3 is in May.
The first site in which I use your module is not that important and a good learning case. I use a solution which can last for some time.

Great you do put such a big effort in this module. I really appreciate it.

Hello pivica,
Thanks for your attachments.
After installing this version the site 2 worked correctly. See: http://www.vriendenvanbeeckestijn.nl/plattegrond.
But site 1 refused to show the correct icons.
I checked the difference in installed modules between site 1 and 2. After disabling module PHPIDS your module worked as promised. After enabling PHPIDS again it still is working. Maybe your module must always be enabled before PHPIDS??
Great! See my result for site 1: http://www.golfenopstraat.nl/plattegrond-route-1-en-2.

I created a new function in gmap3_tools.inc to hide the implementation differences between Drupal version 6 and 7 and to ease the implementation in maps. My proposal for D6 is:

/**
 * Create an image URL
 * This is the URL of an image, mostly an icon, in the tools image map
 * 
 * @param string $image
 */
function gmap3_tools_get_image_url($image) {
  return $GLOBALS['base_url'] . '/' . drupal_get_path('module', 'gmap3_tools') . '/images/' . $image;
}

I found out, the $GLOBALS['base_url'] . '/' . is not neccesary.

There is a small typo in gmap3_tools.inc is: stirng.

As you can see in http://www.golfenopstraat.nl/plattegrond-route-1-en-2: the shadow is not correctly aligned. The shadow comes from the gmap implementation and is equal to: http://labs.google.com/ridefinder/images/mm_20_shadow.png. I still have to manipulate the shadow.png to get it aligned.

Is it possible to define in the new array in gmap3_tools_create_marker() a shadow as well, since the large pin gets the default small shadow as well?

Since the Drupal code grows and grows the trend is to keep as much as possible code out of the modules and place this in a separated .inc. I propose to do this as well with the example in the module and place it in a admin.inc with a switch to enable/disable the display. The example is very usefulle to test whether te module is working, but after that it is not that interesting.

I am sorry I put unrelated issues in this issue.

Thanks for your help. I will implement it in my other sites in coming months. When I have a D5 version, I will upload it.

> I created a new function in gmap3_tools.inc to hide the implementation

Well code in gmap3_tools.module file is just an example code, also that

$GLOBALS['base_url'] . '/' . drupal_get_path('module', 'gmap3_tools') . '/images/druplicon-green.png'

Is only for showing example code so there is really no need for some helper wrapper function or anything else. In your code you just need to pass proper URL to your icons and that is it - this icons should not be in gmap3_tools module.

I didn't create the helper function for your example code, but for all users of the module. Why? When the helper function is present and I use your module in D6 and go to upgrade the site to D7 I don't have to update my own implementation, I just can use the helper function to get the correct image URL.
Otherwise I have to update from D6:
icon = $GLOBALS['base_url'] . '/' . drupal_get_path('module', 'gmap3_tools') . '/images/my_icon.png';
to D7:
icon = file_create_url(drupal_get_path('module', 'gmap3_tools') . '/images/my_icon.png';

With the helper function, I can, in my map, use both in D6, D7 and future versions:
icon = helper_function('my_icon.png');
See: no conversion needed! The Drupal version differences are hidden.

I still are very happy with your help and effort in this module.

Hello pivica,

You are right.
I am using your module without writing a module. I just create a new node and create the map using php code. This is faster then to create a specific module for each site.
And up till now I put the images in the image map of your module to keep everything together. But this isn't a common way how to work.

You are right. I did this allready today and installed the tool in several sites.
I think we can close this issue.