This is a theoretical bug, nevertheless I think it should be fixed:

If you configured the price table to not hide the default price, this module will make this field accessible even if it has been hidden by another hook.


Cybso’s picture

Status: Active » Needs review
1.24 KB

Changes to loop in commerce_price_table_form_commerce_product_ui_product_form_alter(). #access will be only set to false, but never to true.

pcambra’s picture

Status: Needs review » Needs work

As mentioned in the other issue, patches should be provided from module root.

Why are you adding a default price to 0?
Also, entity_metadata_wrapper is nicer for this things instead of accessing the properties directly

Cybso’s picture

Status: Needs work » Needs review
888 bytes

The default price value change is taken from As mentioned in the other issue, I rebuild the patch based on akalata's work for ief integration, and separated it later. I assume he added this because commerce_price must not be empty, but if it is hidden the user cannot enter a value into it.

I've tested it without this change and it works fine for me, so let's remove this part until a bug report is created about this.

pcambra’s picture

Status: Needs review » Fixed

Fixed, I don't think we need to set the price to 0 in any case...

Thanks for the hypothetical catch!! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.