Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
If a badly formed string of resolutions is entered in the setup - e.g.
1400, 1024,878, 800,420 added spaces
or
1400,1024 878,800,420 missing comma
this causes problems as line 58 in adaptive_image.image.inc will take all characters ( including spaces ) between commas to form resolutions that make up the image URL
$derivative_uri = $path_parts['dirname'] . '/' . $resolution . '/' . $path_parts['basename'];
Comment | File | Size | Author |
---|---|---|---|
#5 | 1896356-5-resolutions_field_validation.patch | 944 bytes | n1k |
#4 | 1896356-4-resolutions_field_validation.patch | 946 bytes | n1k |
#3 | 1896356-3-resolutions_field_validation.patch | 2.14 KB | n1k |
#1 | 1896356-resolutions_field_validation.patch | 986 bytes | n1k |
Comments
Comment #1
n1k CreditAttribution: n1k commentedHi,
This patch should validate the input and show an error message if some commas are missing.
Comment #2
sanduhrsCan be combined into one line.
Adhere to the coding standards http://drupal.org/coding-standards#functcall
Please don't use abbreviations.
Adhere to the coding standards http://drupal.org/coding-standards#controlstruct
The first parameter is the form elements name, so probably lower case.
All only minor things, please correct them for the patch to be committed.
Thanks.
Comment #3
n1k CreditAttribution: n1k commentedAdjusted patch to coding standards.
Comment #4
n1k CreditAttribution: n1k commentedFixed file.
Comment #5
n1k CreditAttribution: n1k commentedAnd fixed it again.
Comment #6
sanduhrsCommitted and pushed to 7.x-1.x.
Thanks!