If we pass in an invalid entity type to token_get_entity_mapping('entity', $entity_type), I have a suspicion that the returned value should be the passed in invalid entity type rather than FALSE. It causes problems like #1773926: Token validaiton fails on config edit if the instance context isn't an entity type. Maybe we should add an *optional* fallback for when we don't care for a FALSE value or not.

#1 1894880-token-get-entity-mapping-fallback.patch2.08 KBDave Reid
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es). View


Dave Reid’s picture

Status:Active» Needs review
2.08 KB
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es). View

Let's try this out.

Dave Reid’s picture

Status:Needs review» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.