Since the Media module's image preview doesn't show the cropped version, I sometimes go into the cropping ui just to check where it's cropped. I don't want to change anything and expect a Cancel button to be there. See attached. I realize I can just click Save, but that implies that I've changed something. Please add a Cancel button that closes the cropping ui.

CommentFileSizeAuthor
media_module_preview.png42.8 KBdkingofpa
cropping_ui.png1.01 MBdkingofpa

Comments

matthijs’s picture

matthijs
Primary language Dutch
commented

Hi,

Thanks for the feedback. If you want to quit without saving you can always hit ESC, can you make your peace with that solution or do you really want the button? :-)

Matthijs

dkingofpa’s picture

dkingofpa commented

How are people supposed to know they can just hit ESC? My opinion is that users already understand what a Cancel button means. ESC is a nice shortcut for power users, but most clients are not power users. There's already a Cancel button that displays sometimes. I'd just display it all the time and have consistent functionality.

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Fixed

Hi,

After writing my previous comment I was thinking about this and realized that the cancel button should indeed always be shown. So after some investigating it saw that the cancel button had a faulty class (the same as the reset button), witch caused that button disappeared.

I've just applied and committed the fix!

Matthijs

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.