ConfigMapper was added in #1535868: Convert all blocks into plugins.
As of #1871696: Convert block instances to configuration entities to resolve architectural issues, it will be completely unused.

We're not sure if we'll need it or not, but we need to remove it if it's not used at release

CommentFileSizeAuthor
#2 configmapper-we-hardly-knew-ye-1889748-2.patch1.71 KBtim.plunkett

Comments

eclipsegc’s picture

eclipsegc commented

I'm actively developing condition groups as config entities and plugin composition. Soon as I have this where I want it, I think I'll know for sure if ConfigMapper has a continued spot in core.

Eclipse

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs review
StatusFileSize
new configmapper-we-hardly-knew-ye-1889748-2.patch1.71 KB

Conditions ended up not using this.

eclipsegc’s picture

eclipsegc commented

seems legit, that should totally pass since no one uses it. RTBC assuming green. :-)

Status: Needs review » Needs work
Issue tags: -revisit before beta, -Configuration system, -Plugin system

The last submitted patch, configmapper-we-hardly-knew-ye-1889748-2.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

#2: configmapper-we-hardly-knew-ye-1889748-2.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +revisit before beta, +Configuration system, +Plugin system

#2: configmapper-we-hardly-knew-ye-1889748-2.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

RTBC if it still applies.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d230ea6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Issue summary: View changes
Issue tags: -revisit before beta

The revisit before beta tag was in case this patch was not committed, so it's no longer needed.