Remove default from refresh-after tag [#1889646]

Hi,

I've upgraded nodewords to 6.x-1.14 from 6.x-1.11 and I've noticed that the revisit-after meta tag is now showing on all pages - before the update it didn't show. We don't want to use this tag but setting the value to blank in the UI doesn't remote it and a look at the code suggests it will always default to 1 day if there's no value set.

  $tags['revisit-after'] = $value > 1 ? "$value days" : '1 day';

<meta name="revisit-after" content="1 day">

Is there a way to disable this tag?

Comment	File	Size	Author
#5	nodewords-n1889646-5.patch	1.45 KB	DamienMcKenna

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 16 January 2013 at 23:54

Title:	Any way to disable refresh-after tag?	» Remove default from refresh-after tag
Category:	support	» bug

That's a bug, it shouldn't have a default value like that. Oops, sorry.

Comment #2

serenecloud CreditAttribution: serenecloud commented 28 January 2013 at 21:26

Thanks Damien, good to know I'm not going crazy. Do you have an ETA for a fix or a release target?

Comment #3

serenecloud CreditAttribution: serenecloud commented 10 April 2013 at 05:11

Hey Damien, sorry to keep asking about this but do you know when there will be a patch available? Cheers.

Comment #4

anneeasterling CreditAttribution: anneeasterling commented 22 April 2013 at 19:13

This was also an issue for me. My apologies for not submitting an official patch (and yeah, I need to learn how to do that), so here is my "patched" version of /sites/all/modules/patched/nodewords/nodewords_basic/nodewords_basic.module

Replace line 636-651 with the following:

/**
 * PATCHED TO REQUIRE VALUE BEFORE VALIDATION
 * Validate the meta tag value.
 */
function nodewords_basic_revisit_after_form_validate($element, &$form_state) {
  if (!preg_match('/^[0-9]*$/', $element['#value']) && !empty($element['#value'])) {
    form_error($element, t('The meta tag REVISIT-AFTER value must be a positive number.'));
  }
}

/**
 * PATCHED TO REQUIRE VALUE BEFORE SETTING REVISIT-AFTER TAG
 * Set the meta tag content.
 */
function nodewords_basic_revisit_after_prepare(&$tags, $content, $options) {
  if (!empty($content['value'])) {
    $value = ($content['value']);
    $tags['revisit-after'] = $value > 1 ? "$value days" : '1 day';
  }
}

This works on the site that I'm working on now. Improvements are welcome!

Thanks,
Anne