Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
If you have an attachment with only one linked display the summary code breaks,
because the storage got converted to protected properties some time ago.
There is test coverage for multiple displays but not for a single one, so that specific part of the code is never runned in the test.
Comment | File | Size | Author |
---|---|---|---|
#12 | drupal-1888954-12.patch | 3.65 KB | dawehner |
#9 | drupal-1888954-9.patch | 3.64 KB | dawehner |
#9 | interdiff.txt | 3.07 KB | dawehner |
#7 | drupal-1888954-7.patch | 3.33 KB | dawehner |
#5 | drupal-1888954-5.patch | 3.32 KB | dawehner |
Comments
Comment #1
dawehnerHere are both a test-only patch and one with a proper fix.
Comment #3
dawehnerBack to needs review.
Comment #4
tim.plunkett#1: drupal-1888954-1.patch queued for re-testing.
Comment #5
dawehnerRerole.
Comment #7
dawehnerThat one should work.
Comment #8
tim.plunkettThis drupalGet is redundant, they can be combined into the drupalPost
What is the array_filter removing? No problem, just curious.
Comment #9
dawehnerLet's better filter out the empty elements in the submit function.
Comment #10
dawehner#9: drupal-1888954-9.patch queued for re-testing.
Comment #12
dawehnerJust a rerole.
Comment #14
dawehner#12: drupal-1888954-12.patch queued for re-testing.
Comment #15
damiankloip CreditAttribution: damiankloip commentedLooks good.
Comment #16
alexpottCommitted b0aa1ae and pushed to 8.x. Thanks!