Attachments with only display cause a php error in the edit UI [#1888954]

Comment	File	Size	Author
#12	drupal-1888954-12.patch	3.65 KB	dawehner
#9	drupal-1888954-9.patch	3.64 KB	dawehner
#9	interdiff.txt	3.07 KB	dawehner
#7	drupal-1888954-7.patch	3.33 KB	dawehner
#5	drupal-1888954-5.patch	3.32 KB	dawehner
#1	drupal-1888954-1.patch	3.4 KB	dawehner
#1	drupal-1888954-tests.patch	2.61 KB	dawehner

Comment #1

dawehner

German

commented 15 January 2013 at 08:18

Status:

Active

» Needs review

Status	File	Size
new	drupal-1888954-tests.patch	2.61 KB
new	drupal-1888954-1.patch	3.4 KB

Here are both a test-only patch and one with a proper fix.

Log in or register to post comments

Comment #2

15 January 2013 at 09:28

Status:

Needs review

» Needs work

The last submitted patch, drupal-1888954-tests.patch, failed testing.

Log in or register to post comments

Comment #3

dawehner

German

commented 15 January 2013 at 12:32

Status:

Needs work

» Needs review

Back to needs review.

Log in or register to post comments

Comment #4

tim.plunkett

he/him

English

Philadelphia

commented 5 February 2013 at 17:31

#1: drupal-1888954-1.patch queued for re-testing.

Log in or register to post comments

Comment #5

dawehner

German

commented 5 February 2013 at 20:38

Status	File	Size
new	drupal-1888954-5.patch	3.32 KB

Rerole.

Log in or register to post comments

Comment #6

5 February 2013 at 21:28

Status:

Needs review

» Needs work

The last submitted patch, drupal-1888954-5.patch, failed testing.

Log in or register to post comments

Comment #7

dawehner

German

commented 6 February 2013 at 23:04

Status:

Needs work

» Needs review

Status	File	Size
new	drupal-1888954-7.patch	3.33 KB

That one should work.

Log in or register to post comments

Comment #8

tim.plunkett

he/him

English

Philadelphia

commented 14 February 2013 at 20:45

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/DisplayAttachmentTest.phpundefined
@@ -36,18 +36,32 @@ public function testAttachmentUI() {
+    $this->drupalGet($attachment_display_url);
+    $this->drupalPost(NULL, array('displays[page_1]' => 1), t('Apply'));
...
+    $this->drupalGet($attachment_display_url);
     $this->drupalPost(NULL, array('displays[default]' => 1, 'displays[page_1]' => 1), t('Apply'));

This drupalGet is redundant, they can be combined into the drupalPost

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/DisplayAttachmentTest.phpundefined
@@ -36,18 +36,32 @@ public function testAttachmentUI() {
+    $this->assertEqual(array_keys(array_filter($view->displayHandlers->get('attachment_1')->getOption('displays'))), array('page_1'), 'The attached displays got saved as expected');

What is the array_filter removing? No problem, just curious.