If you have an attachment with only one linked display the summary code breaks,
because the storage got converted to protected properties some time ago.

There is test coverage for multiple displays but not for a single one, so that specific part of the code is never runned in the test.

Files: 
CommentFileSizeAuthor
#12 drupal-1888954-12.patch3.65 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,916 pass(es). View
#9 drupal-1888954-9.patch3.64 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1888954-9.patch. Unable to apply patch. See the log in the details link for more information. View
#9 interdiff.txt3.07 KBdawehner
#7 drupal-1888954-7.patch3.33 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 49,203 pass(es). View
#5 drupal-1888954-5.patch3.32 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 49,061 pass(es), 1 fail(s), and 0 exception(s). View
#1 drupal-1888954-1.patch3.4 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1888954-1.patch. Unable to apply patch. See the log in the details link for more information. View
#1 drupal-1888954-tests.patch2.61 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 50,823 pass(es), 2 fail(s), and 1 exception(s). View

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
2.61 KB
FAILED: [[SimpleTest]]: [MySQL] 50,823 pass(es), 2 fail(s), and 1 exception(s). View
3.4 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1888954-1.patch. Unable to apply patch. See the log in the details link for more information. View

Here are both a test-only patch and one with a proper fix.

Status: Needs review » Needs work

The last submitted patch, drupal-1888954-tests.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

Back to needs review.

tim.plunkett’s picture

#1: drupal-1888954-1.patch queued for re-testing.

dawehner’s picture

FileSize
3.32 KB
FAILED: [[SimpleTest]]: [MySQL] 49,061 pass(es), 1 fail(s), and 0 exception(s). View

Rerole.

Status: Needs review » Needs work

The last submitted patch, drupal-1888954-5.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
3.33 KB
PASSED: [[SimpleTest]]: [MySQL] 49,203 pass(es). View

That one should work.

tim.plunkett’s picture

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/DisplayAttachmentTest.phpundefined
@@ -36,18 +36,32 @@ public function testAttachmentUI() {
+    $this->drupalGet($attachment_display_url);
+    $this->drupalPost(NULL, array('displays[page_1]' => 1), t('Apply'));
...
+    $this->drupalGet($attachment_display_url);
     $this->drupalPost(NULL, array('displays[default]' => 1, 'displays[page_1]' => 1), t('Apply'));

This drupalGet is redundant, they can be combined into the drupalPost

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/DisplayAttachmentTest.phpundefined
@@ -36,18 +36,32 @@ public function testAttachmentUI() {
+    $this->assertEqual(array_keys(array_filter($view->displayHandlers->get('attachment_1')->getOption('displays'))), array('page_1'), 'The attached displays got saved as expected');

What is the array_filter removing? No problem, just curious.

dawehner’s picture

FileSize
3.07 KB
3.64 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1888954-9.patch. Unable to apply patch. See the log in the details link for more information. View

Let's better filter out the empty elements in the submit function.

dawehner’s picture

Issue tags: -VDC

#9: drupal-1888954-9.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, drupal-1888954-9.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
3.65 KB
PASSED: [[SimpleTest]]: [MySQL] 55,916 pass(es). View

Just a rerole.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, drupal-1888954-12.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
Issue tags: +VDC

#12: drupal-1888954-12.patch queued for re-testing.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b0aa1ae and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.