I'm using Node Gallery in Drupal 7 and got it working with plupload function.
When I use the Manage tab, everything works, but when I use the Sort tab it doesn't.
I can drag items to sort, but when saving the custom sorting, default sorting view appears again...

Anyone any clue on this?

Thanks in advance!

CommentFileSizeAuthor
#1 node-gallery-views-sort-order-1888284-1.patch6.35 KBzengenuity

Comments

zengenuity’s picture

zengenuity commented
Status: Active » Needs review
StatusFileSize
new node-gallery-views-sort-order-1888284-1.patch6.35 KB

It looks like I screwed up the sort order in the default item views awhile back. This patch should fix it, but after applying, you need to revert the view called "Node Gallery: Gallery Item Views". This can be done under Structure, Views. Expand the edit button and choose "revert".

For others who may have intentionally customized this view, don't revert it, but make sure the sort order includes Node Gallery weight, tied to the Node Gallery Relationship views relationship.

vincent rommelaars’s picture

vincent rommelaars commented

Great,

this workd as it should. Thanks!
However, when you click the sort button, first the Jquery sort page appears and user first have to click the link in:
"To change the weight of the gallery items, drag and drop them below. If you wish to use the jquery drag & drop sorting, click here."
Is there an easy way to switch this one?

Thanks in advance...

vincent rommelaars’s picture

vincent rommelaars commented
Status: Needs review » Closed (fixed)

Got it working!
Deinstalled module.
Installed again and applied patch.
Revert view and it works.

Thanks!

zengenuity’s picture

zengenuity commented
Status: Closed (fixed) » Needs review

Okay, glad it is working. Please don't close issues though.

zengenuity’s picture

zengenuity commented

Committed: http://drupalcode.org/project/node_gallery.git/commit/c16edba

zengenuity’s picture

zengenuity commented
Status: Needs review » Fixed
quicksketch’s picture

quicksketch
he/him
commented
Category: support » bug

Just ran into this today. Thanks @zengenuity for correcting it.

+  // @todo: Fix jquery UI integration.
+  // $jquery_ui_integration = variable_get('node_gallery_jquery_ui_integration', TRUE) && $no_jquery != 'no_jquery';
+  $jquery_ui_integration = FALSE;

Rather than forcing this variable to be false, I found that it might be better just to skip checking that variable at all. Changing this section to simply not be conditional, since it's needed for both jQuery and non-jQuery versions:

    if (!$jquery_ui_integration) {
      $form['images-sort-' . $i] = array(
        '#type' => 'weight',
        '#delta' => $image_count,
        '#default_value' => $i,
        '#attributes' => array(
          'class' => array('sort'),
        ),
      );
    }

Anyway, current solution works too, so good enough for me.

zengenuity’s picture

zengenuity commented

Yeah, that was a quick hack that I forgot to go back and clean up. There was a bit more code that needed to be removed in the submit handler, as well. http://drupalcode.org/project/node_gallery.git/commit/f3144cc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

sorting