Problem

Block visibility summaries used to work as regular vertical tabs summaries providing a short overview of the block visibility setup. The fields were renamed, but visibility JS was not updated in #1535868: Convert all blocks into plugins.

Proposal

Fix the JS by updating it to the right selectors. Also remove user based visibility JS since the feature was removed. #1871854: Decide whether to restore per-user block visibility or provide it in contrib).

SummaryBefore.png

SummaryAfter.png

CommentFileSizeAuthor
block-visibility-js.patch1.45 KBGábor Hojtsy
SummaryAfter.png52.66 KBGábor Hojtsy
SummaryBefore.png47.13 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Although not depicted on the screenshot, I cross-checked with language visibility as well and that works too.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Title: Block visibility summaries are broken » Regression: Block visibility summaries are broken

Titling to call regression into focus.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

nice catch! i would have never notice it

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Block plugins

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.