Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Drush adds d.o-style .info information for my private modules, causing Drupal to then check Drupal.org for updates to them.
Not sure how best to proceed. Checking for update info on d.o for each module seems excessive. Possibly only do .info rewriting for modules that have default (d.o) git repos?
Comment | File | Size | Author |
---|---|---|---|
#5 | no-info-private-repos-1881378-05.patch | 696 bytes | jhedstrom |
#2 | drush-make-1881378-02.patch | 871 bytes | jhedstrom |
Comments
Comment #1
jhedstromOnly rewriting for d.o. seems like the way to go.
Comment #2
jhedstromPatch attached.
Comment #3
jhedstromOops, #2 is for a different issue (#1881380: .info rewriting broken for modules without a release).
Comment #4
dkingofpa CreditAttribution: dkingofpa commentedIt also causes
git status
andgit diff
to show changes in private repos when it's only the .info rewriting. It's a constant nuisance.I was previously coming at this from the 7.x-5.x-dev version on #1890234: Do not override properties in .info files.
Comment #5
jhedstromThis should do the trick.
Comment #6
lotyrin CreditAttribution: lotyrin commentedYep. That seems adequate.
Comment #7
moshe weitzman CreditAttribution: moshe weitzman commentedComment #8
jhedstromThis was actually committed back in January (764ab31d).
Comment #10
jdillick CreditAttribution: jdillick commentedDoes anyone think the patch from #5 might break automated build processes for peeps who rely on drush make *to* put the versions in their custom modules? Any particular reason this couldn't bale on an argument --no-gitinfofile?
This is dissappointing. A behavior change such as this, which break version based dependencies, seems inappropriate, especially at version 5.9.
Comment #11
jdillick CreditAttribution: jdillick commentedComment #12
greg.1.anderson CreditAttribution: greg.1.anderson commentedThis issue was marked
closed (won't fix)
because Drush has moved to Github.If desired, you may copy this bug to our Github project and then post a link here to the new issue. Please also change the status of this issue to
closed (duplicate)
.Please ask support questions on Drupal Answers.