When saving the settings on this plugin there is no response.

No "Settings saved" dialog or something like that...

CommentFileSizeAuthor
#13 lazyloader-save_settings_multilingual-1876144-13.patch582 bytesabsoludo
#12 lazyloader-1876144-12.patch1.32 KBparavibe
#11 lazyload.diff5.12 KBjosmera01
#7 lazyloader-Fix_can_not_save_the_configuration.patch706 bytesxiukun.zhou
#2 lazyloader-settings_not_saved-1876144-2.patch519 bytesdoitDave

Comments

doitDave’s picture

doitDave commented
Title: No response when saving settings » Settings not saved at all
Version: 7.x-1.x-dev » 7.x-1.3
Priority: Normal » Major

It's not just that there is no "settings saved" dialog, but the settings are not even being saved. All I find in the variables table is a variable named 'lazyloader' but it sticks to the serialized value "N;" which is NULL.

The problem occurs when using your site in a language other than english (i.e. a translated site). It is caused by missing t() calls, see patch in the follow-up comment.

doitDave’s picture

doitDave commented
Status: Active » Needs review
StatusFileSize
new lazyloader-settings_not_saved-1876144-2.patch519 bytes

Patch for the missing translations.

doitDave’s picture

doitDave commented

OK guys. I am unfollowing. Hopefully my patch will at least help some of those who ran into the same problem. Cheers.

juliusvaart’s picture

juliusvaart commented

Thanks doitDave!

13rac1’s picture

13rac1 commented
Version: 7.x-1.3 » 7.x-1.x-dev
Status: Needs review » Needs work

Doesn't apply to current dev, but the maintainer could easily fix w/o a patch.

jordanmagnuson’s picture

jordanmagnuson commented
Title: Settings not saved at all » Settings not saved at all if using translation

Making title more specific...

xiukun.zhou’s picture

xiukun.zhou commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new lazyloader-Fix_can_not_save_the_configuration.patch706 bytes

Fix to dev

rolfmeijer’s picture

rolfmeijer commented

Tested the dev-version of 2013-Sep-30 with the patch above (#7) and it works as intended.
Thank you.

abugge’s picture

abugge commented
Component: User interface » Miscellaneous

I have this problem to even with the dev version installed. I does not save settings at all.

rolfmeijer’s picture

rolfmeijer commented

abugge, you need the dev-version AND the patch from comment 7.

josmera01’s picture

josmera01 commented
StatusFileSize
new lazyload.diff5.12 KB

How applying patch with the module drush remake,

projects[lazyloader][version] = 1.3
projects[lazyloader][type] = "module"
projects[lazyloader][patch][rfc-fixes][url] = URL/lazyload.diff

The version dev the module is stable.

paravibe’s picture

paravibe commented
StatusFileSize
new lazyloader-1876144-12.patch1.32 KB

Hi guys!
Patches above doesn't work for me.
Site has 2 languages. English is not default.
So if I switch to English it works but when trying to save when default language is chosen it doesn't save.
Below is patch that works for me. Please review.

absoludo’s picture

absoludo commented
Status: Needs review » Patch (to be ported)
StatusFileSize
new lazyloader-save_settings_multilingual-1876144-13.patch582 bytes

Patch #7 is a nice and clean sollution, but does not apply to version 7.x-1.3.
I created a patch based on #7 that does apply to that version.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Patch (to be ported) » Fixed

Manually applied the patch and committed, thank you!

  • doitDave authored 6e1671e on 7.x-1.x 
    Issue #1876144 by doitDave, absoludo: Settings not saved at all if using...
juliusvaart’s picture

juliusvaart commented
Status: Fixed » Patch (to be ported)
juliusvaart’s picture

juliusvaart commented
Status: Patch (to be ported) » Fixed

Sorry about that.

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

doitDave’s picture

doitDave commented

Oh, good to see it finally helped. :)