I have an error on node-page:

Warning: Illegal string offset 'field' in function commentaccess_query_comment_filter_alter() (line 248 in file /site.com/sites/all/modules/commentaccess/commentaccess.module).

This patch works fine: http://drupal.org/node/1414412#comment-5703050

CommentFileSizeAuthor
#8 fix_illegal_string_offset-1875454-8.patch752 bytesformatC'vt
#4 commentaccess-1875454-4-conjunction-check-on-hook_query_TAG_alter.patch658 bytesalan d.

Comments

Fidelix’s picture

Fidelix commented

Applying that patch did not fix the problem for me.

Fidelix’s picture

Fidelix commented
Priority: Normal » Major

The module is unusable on PHP 5.4.
I see that some modules with the same problem fixed it in their end, so I'm bumping this to major.

Sean-Khan’s picture

Sean-Khan commented

I confirm, I get the error & that the patch has no effect for me either.

alan d.’s picture

alan d. commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new commentaccess-1875454-4-conjunction-check-on-hook_query_TAG_alter.patch658 bytes

;)

alan d.’s picture

alan d. commented
Issue summary: View changes

Sorry, line 248 not 250

pradeep22saini’s picture

pradeep22saini commented

foreach ($conditions as $key => &$condition) {
+ if(is_array($condition)){
if ($condition['field'] == 'c.status' && $condition['value'] == COMMENT_PUBLISHED) {
unset($conditions[$key]);
}
+ }
}
I have added + if(is_array($condition)){ this condition of Is_array() and it removed the error. I don't know how to make patch. But adding this solved my problem.

loze’s picture

loze commented

Patch in #4 works for me. Thanks!

JBecker’s picture

JBecker commented

Patch #4 works.

formatC'vt’s picture

formatC'vt commented
Issue summary: View changes
StatusFileSize
new fix_illegal_string_offset-1875454-8.patch752 bytes

Works, but hardcoding for '#conjunction' this is bad solution.
We should check existing keys. Patch attached.

formatC'vt’s picture

formatC'vt commented
Status: Needs review » Fixed

thanks, committed

  • formatC'vt committed 8f42c9b on 7.x-1.x 
    Issue #1875454 by Alan D., formatC'vt: PHP 5.4 Warning: Illegal string...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cheans’s picture

cheans commented

Patch #4 works fine for me. Thanks~~

mausolos’s picture

mausolos commented

#8 patch worked for me against php7