Refactored core Twig integration [#1873442]

Problem/Motivation

Right now, Twig is bootstrapped/configured via the TwigFactory class. This makes almost impossible to cleanly add extensions on Twig or change the loader.

Proposed resolution

The proposed patch :

* removes the factory and replaces it with proper configuration in the container;
* moves all custom filters/node visitors/tags/functions to a new Drupal Twig extension;
* the render function has been renamed to drupal_render to avoid collision with the same function from the Twig bridge in Symfony. AFAIU, this is only used internally and as such, it should not be a problem.
* the loader is now a service (twig.loader.filesystem) and an alias has been made to twig.loader (which is used by the Twig service). This allows for better flexibility (you can add your own loader for instance by replacing the twig.loader service with a Twig_Loader_Chain one that keeps the default filesystem loader and your own).

Comment	File	Size	Author
#5	twig_refactoring_5.patch	10.61 KB	fabpot
	twig_refactoring.patch	8.89 KB	fabpot

Comments

Comment #1

Crell commented 25 December 2012 at 00:25

Status:

Needs review

» Needs work

This makes sense, I think. The registerTwig() method needs a docblock, however.

Comment #2

chx commented 25 December 2012 at 02:25

While this is very very lovely, calling render drupal_render is going to be somewhat confusing -- but as it's not exposed to the outside world, it's OK. Here's why: render also includes a show() command which drupal_render doesn't.

Comment #3

fabpot commented 25 December 2012 at 09:39

I don't have any preferences for the drupal_render name. Any suggestions?

Comment #4

Crell commented 25 December 2012 at 18:08

drender()? render_array()? render_struct()? (I don't have a strong preference, just throwing out ideas.)

Comment #5

fabpot commented 26 December 2012 at 08:28

Status	File	Size
new	twig_refactoring_5.patch	10.61 KB

I've renamed drupal_render to render_var, which probably best describes what it does (and it is kind of symmetric with the twig_render_template function) .

I've also added a phpdoc to the registerTwig() method as requested.